Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2861063004: Add new UrlPatternIndex test. (Closed)

Created:
3 years, 7 months ago by pkalinnikov
Modified:
3 years, 7 months ago
Reviewers:
karandeepb, engedy
CC:
chromium-reviews, subresource-filter-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new UrlPatternIndex test. The new test verifies that FindMatch returns meaningful data. BUG=713774 Review-Url: https://codereview.chromium.org/2861063004 Cr-Commit-Position: refs/heads/master@{#469941} Committed: https://chromium.googlesource.com/chromium/src/+/d27b3ffe038eba9c733337eccec5dae067118521

Patch Set 1 #

Patch Set 2 : Add out-of-range check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M components/subresource_filter/core/common/url_pattern_index_unittest.cc View 1 3 chunks +39 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
pkalinnikov
Balazs and Karan, PTAL.
3 years, 7 months ago (2017-05-05 12:19:54 UTC) #4
engedy
LGTM, thanks!
3 years, 7 months ago (2017-05-05 17:51:34 UTC) #7
karandeepb
lgtm
3 years, 7 months ago (2017-05-05 20:22:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861063004/20001
3 years, 7 months ago (2017-05-08 08:23:55 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 09:47:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d27b3ffe038eba9c733337eccec5...

Powered by Google App Engine
This is Rietveld 408576698