content/browser/browsing_data/browsing_data_remover_impl_unittest.cc - Issue 2861063003: Remove dangerous CanonicalCookie::Create method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browsing_data/browsing_data_remover_impl_unittest.cc

Issue 2861063003: Remove dangerous CanonicalCookie::Create method. (Closed)

Patch Set: Content unittest changes. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/signin/core/browser/gaia_cookie_manager_service.cc ('k') | content/browser/net/quota_policy_cookie_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browsing_data/browsing_data_remover_impl_unittest.cc

diff --git a/content/browser/browsing_data/browsing_data_remover_impl_unittest.cc b/content/browser/browsing_data/browsing_data_remover_impl_unittest.cc

index 762f38f867d3dd4168b8230597728ba0e0f759fa..2b5cea3e17814aee7bc5068d35f2acfd679ffe2a 100644

--- a/content/browser/browsing_data/browsing_data_remover_impl_unittest.cc

+++ b/content/browser/browsing_data/browsing_data_remover_impl_unittest.cc

@@ -118,8 +118,8 @@ struct StoragePartitionRemovalData {

net::CanonicalCookie CreateCookieWithHost(const GURL& source) {

std::unique_ptr<net::CanonicalCookie> cookie(net::CanonicalCookie::Create(

- source, "A", "1", std::string(), "/", base::Time::Now(),

- base::Time::Now(), false, false, net::CookieSameSite::DEFAULT_MODE,

+ "A", "1", "." + source.host(), "/", base::Time::Now(), base::Time::Now(),

mmenke 2017/05/05 17:51:56 I think this used to be exact matches? (i.e., no

Randy Smith (Not in Mondays) 2017/05/05 21:12:58 Yep, oops. Doesn't change the test outcome to fix

+ base::Time(), false, false, net::CookieSameSite::DEFAULT_MODE,

net::COOKIE_PRIORITY_MEDIUM));

EXPECT_TRUE(cookie);

return *cookie;