Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2861013002: Clear callback when a parallel request can no longer write any data (Closed)

Created:
3 years, 7 months ago by qinmin
Modified:
3 years, 7 months ago
Reviewers:
xingliu
CC:
chromium-reviews, David Trainor- moved to gerrit, vmpstr+watch_chromium.org, jam, darin-cc_chromium.org, agrieve+watch_chromium.org, danakj+watch_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Clear callback when a parallel request can no longer write any data If a StreamReader is found that it can no longer write any data, we should clear its callback. Otherwise, the StreamReader can still report an error and interrupt the download. TBR=xingliu@chromium.org BUG=717719 If the data has already been written Review-Url: https://codereview.chromium.org/2861443005 Cr-Commit-Position: refs/heads/master@{#469193} (cherry picked from commit 2a542d8debc1075277dfa8de50dea36fb96d5aff) Catch more exception when accessing content URI Accessing content URI can throw more exceptions than expected. This CL catch all possible exceptions so we don't crash. BUG=706299 Review-Url: https://codereview.chromium.org/2861583008 Cr-Commit-Position: refs/heads/master@{#469208} (cherry picked from commit 62b10acb8db135704af395a51ecf72d499944d76) Review-Url: https://codereview.chromium.org/2861013002 . Cr-Commit-Position: refs/branch-heads/3071@{#403} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/c9f4cf07ee20ae79f205f85610969ecb64c9dd3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -5 lines) Patch
M base/android/java/src/org/chromium/base/ContentUriUtils.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/download/download_file_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/download/download_file_unittest.cc View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
3 years, 7 months ago (2017-05-04 16:58:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c9f4cf07ee20ae79f205f85610969ecb64c9dd3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698