VR: Enable browsing for CCT and make ui_scene_manager aware of whether we're in CCT.

VR: Enable browsing for CCT and make ui_scene_manager aware of whether we're in CCT.

Note that this is still behind the "Chrome VR" runtime flag.

BUG=718664
Review-Url: https://codereview.chromium.org/2861003003
Cr-Commit-Position: refs/heads/master@{#469662}
Committed: https://chromium.googlesource.com/chromium/src/+/3d454e4a0d506af33ec1b706bbf12d07490ede4a

[mthiesse, 2017-05-05 00:53:01]

mthiesse@chromium.org changed reviewers:
+ cjgrant@chromium.org, ymalik@chromium.org

[mthiesse, 2017-05-05 00:53:01]

PTAL

[cjgrant, 2017-05-05 14:21:56]

lgtm

https://codereview.chromium.org/2861003003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2861003003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:86: bool in_cct,
General observation (discussed offline).  We have a few bits of info, 'for
webvr' and 'in cct' coming via constructor, and other information coming via
calls posted after the fact.  Maybe in the future we should send all such
information after the fact, but have scene manager be smart enough to know it
needs to wait for certain pieces of information before building the scene.  As
the "manager", the brains of sorting out when to draw is supposed to belong
there...  food for thought.

[mthiesse, 2017-05-05 14:23:19]

Description was changed from

==========
VR: Enable browsing for CCT and make ui_scene_manager aware of whether we're in
CCT.

BUG=718664
==========

to

==========
VR: Enable browsing for CCT and make ui_scene_manager aware of whether we're in
CCT.

Note that this is still behind the "Chrome VR" runtime flag.

BUG=718664
==========

[mthiesse, 2017-05-05 14:25:57]

https://codereview.chromium.org/2861003003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2861003003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:86: bool in_cct,
On 2017/05/05 14:21:56, cjgrant wrote:
> General observation (discussed offline).  We have a few bits of info, 'for
> webvr' and 'in cct' coming via constructor, and other information coming via
> calls posted after the fact.  Maybe in the future we should send all such
> information after the fact, but have scene manager be smart enough to know it
> needs to wait for certain pieces of information before building the scene.  As
> the "manager", the brains of sorting out when to draw is supposed to belong
> there...  food for thought.

Agreed in general, but for cct state in particular I think it makes sense to
keep it a constructor parameter as it'll never change.

[mthiesse, 2017-05-05 14:26:08]

The CQ bit was checked by mthiesse@chromium.org

[commit-bot: I haz the power, 2017-05-05 14:26:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 14:29:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 14:29:19]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ymalik, 2017-05-05 14:32:53]

lgtm

https://codereview.chromium.org/2861003003/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_scene_manager.cc (right):

https://codereview.chromium.org/2861003003/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_scene_manager.cc:50: : scene_(scene),
in_cct_(in_cct), weak_ptr_factory_(this) {
This may have merge conflicts with
https://codereview.chromium.org/2833773005/diff/140001/chrome/browser/android...

[mthiesse, 2017-05-05 14:53:02]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-05-05 14:53:03]

The patchset sent to the CQ was uploaded after l-g-t-m from ymalik@chromium.org,
cjgrant@chromium.org
Link to the patchset: https://codereview.chromium.org/2861003003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-05 14:53:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mthiesse, 2017-05-05 15:11:23]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-05-05 15:11:24]

The patchset sent to the CQ was uploaded after l-g-t-m from ymalik@chromium.org,
cjgrant@chromium.org
Link to the patchset: https://codereview.chromium.org/2861003003/#ps40001
(title: "Fix test compile")

[commit-bot: I haz the power, 2017-05-05 15:11:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 15:52:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493997083952420,
"parent_rev": "e52d6fd1823e30a6de77487ca0ca9aace6f9f844", "commit_rev":
"3d454e4a0d506af33ec1b706bbf12d07490ede4a"}

[commit-bot: I haz the power, 2017-05-05 15:53:00]

Description was changed from

==========
VR: Enable browsing for CCT and make ui_scene_manager aware of whether we're in
CCT.

Note that this is still behind the "Chrome VR" runtime flag.

BUG=718664
==========

to

==========
VR: Enable browsing for CCT and make ui_scene_manager aware of whether we're in
CCT.

Note that this is still behind the "Chrome VR" runtime flag.

BUG=718664

Review-Url: https://codereview.chromium.org/2861003003
Cr-Commit-Position: refs/heads/master@{#469662}
Committed:
https://chromium.googlesource.com/chromium/src/+/3d454e4a0d506af33ec1b706bbf1...
==========

[commit-bot: I haz the power, 2017-05-05 15:53:01]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3d454e4a0d506af33ec1b706bbf1...

[jbizle101, 2017-05-12 23:51:16]

johngladue85@gmail.com changed reviewers:
+ johngladue85@gmail.com

[jbizle101, 2017-05-12 23:51:16]

lgtm

lgtm

Root  pi stack meta sec mix match preambles assenblies Xcode 200rooted