Harmony: Apply the upper bound on equal-sized button widths in DialogClientView.

Harmony: Apply the upper bound on equal-sized button widths in DialogClientView.

This involves moving the layout constant into views. The explicit check
for IsSecondaryUiMaterial() is no longer needed since linking with an
upper bound of 0 pixels has the same effect as not linking at all.

Also, reduce the upper bound from 128 to 112 pixels, per
http://crbug.com/671820#c19

BUG=671820
Review-Url: https://codereview.chromium.org/2860953002
Cr-Commit-Position: refs/heads/master@{#469929}
Committed: https://chromium.googlesource.com/chromium/src/+/bee127cb13495a34bdf6e05c5729840c2a0a89a1

[tapted, 2017-05-04 06:00:09]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 06:00:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 06:48:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 06:48:51]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-05-04 07:17:15]

Description was changed from

==========
Harmony: Apply the upper bound on equal-sized button widths in DialogClientView


BUG=671820
==========

to

==========
Harmony: Apply the upper bound on equal-sized button widths in DialogClientView.

This involves moving the layout constant into views. The explicit check
for IsSecondaryUiMaterial is no longer needed since linking with an
upper bound of 0 pixels has the same effect as not linking at all.

Also, reduce the upper bound from 128 to 112 pixels, per
http://crbug.com/671820#c19

BUG=671820
==========

[tapted, 2017-05-04 07:17:15]

tapted@chromium.org changed reviewers:
+ msw@chromium.org

[tapted, 2017-05-04 07:17:37]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 07:17:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-05-04 07:17:54]

Description was changed from

==========
Harmony: Apply the upper bound on equal-sized button widths in DialogClientView.

This involves moving the layout constant into views. The explicit check
for IsSecondaryUiMaterial is no longer needed since linking with an
upper bound of 0 pixels has the same effect as not linking at all.

Also, reduce the upper bound from 128 to 112 pixels, per
http://crbug.com/671820#c19

BUG=671820
==========

to

==========
Harmony: Apply the upper bound on equal-sized button widths in DialogClientView.

This involves moving the layout constant into views. The explicit check
for IsSecondaryUiMaterial() is no longer needed since linking with an
upper bound of 0 pixels has the same effect as not linking at all.

Also, reduce the upper bound from 128 to 112 pixels, per
http://crbug.com/671820#c19

BUG=671820
==========

[commit-bot: I haz the power, 2017-05-04 08:06:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 08:06:43]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-05-04 09:06:19]

Hi Mike, please take a look - hopefully the last one for http://crbug.com/671820
- Thanks!

[msw, 2017-05-05 18:07:43]

lgtm with test nits

https://codereview.chromium.org/2860953002/diff/40001/ui/views/window/dialog_...
File ui/views/window/dialog_client_view_unittest.cc (right):

https://codereview.chromium.org/2860953002/diff/40001/ui/views/window/dialog_...
ui/views/window/dialog_client_view_unittest.cc:168: class TestLayoutProvider :
public LayoutProvider {
nit: Can you move this to its own file and use that in
bubble_frame_view_unittest.cc?

https://codereview.chromium.org/2860953002/diff/40001/ui/views/window/dialog_...
ui/views/window/dialog_client_view_unittest.cc:408:
layout_provider.Set(DISTANCE_BUTTON_MAX_LINKABLE_WIDTH, 100);
nit: EXPECT_GT(cancel_button_width, 100)?

[tapted, 2017-05-08 02:59:58]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 03:00:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 04:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 04:03:42]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tapted, 2017-05-08 06:53:57]

Thanks Mike!

https://codereview.chromium.org/2860953002/diff/40001/ui/views/window/dialog_...
File ui/views/window/dialog_client_view_unittest.cc (right):

https://codereview.chromium.org/2860953002/diff/40001/ui/views/window/dialog_...
ui/views/window/dialog_client_view_unittest.cc:168: class TestLayoutProvider :
public LayoutProvider {
On 2017/05/05 18:07:43, msw wrote:
> nit: Can you move this to its own file and use that in
> bubble_frame_view_unittest.cc?

Done.

https://codereview.chromium.org/2860953002/diff/40001/ui/views/window/dialog_...
ui/views/window/dialog_client_view_unittest.cc:408:
layout_provider.Set(DISTANCE_BUTTON_MAX_LINKABLE_WIDTH, 100);
On 2017/05/05 18:07:43, msw wrote:
> nit: EXPECT_GT(cancel_button_width, 100)?

Done.

[tapted, 2017-05-08 06:54:48]

The CQ bit was checked by tapted@chromium.org

[tapted, 2017-05-08 06:54:48]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2860953002/#ps100001
(title: "test_layout_provider.h, sanity checks, self-review: nit data member
names")

[commit-bot: I haz the power, 2017-05-08 06:55:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 09:04:30]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494226488022430,
"parent_rev": "b19c6575a331d41e4fcc6dc742d2abcfebc0430e", "commit_rev":
"bee127cb13495a34bdf6e05c5729840c2a0a89a1"}

[commit-bot: I haz the power, 2017-05-08 09:04:37]

Description was changed from

==========
Harmony: Apply the upper bound on equal-sized button widths in DialogClientView.

This involves moving the layout constant into views. The explicit check
for IsSecondaryUiMaterial() is no longer needed since linking with an
upper bound of 0 pixels has the same effect as not linking at all.

Also, reduce the upper bound from 128 to 112 pixels, per
http://crbug.com/671820#c19

BUG=671820
==========

to

==========
Harmony: Apply the upper bound on equal-sized button widths in DialogClientView.

This involves moving the layout constant into views. The explicit check
for IsSecondaryUiMaterial() is no longer needed since linking with an
upper bound of 0 pixels has the same effect as not linking at all.

Also, reduce the upper bound from 128 to 112 pixels, per
http://crbug.com/671820#c19

BUG=671820

Review-Url: https://codereview.chromium.org/2860953002
Cr-Commit-Position: refs/heads/master@{#469929}
Committed:
https://chromium.googlesource.com/chromium/src/+/bee127cb13495a34bdf6e05c5729...
==========

[commit-bot: I haz the power, 2017-05-08 09:04:38]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/bee127cb13495a34bdf6e05c5729...