components/pdf/renderer/pdf_accessibility_tree.cc - Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/pdf/renderer/pdf_accessibility_tree.cc

Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData. (Closed)

Patch Set: Delete AXNodeData::Init() and clear bitfields in AXNodeData() instead. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/pdf/renderer/pdf_accessibility_tree.cc

diff --git a/components/pdf/renderer/pdf_accessibility_tree.cc b/components/pdf/renderer/pdf_accessibility_tree.cc

index d4c225784253cde2bbde6fd17b8dddfdc08abcbf..4512380c8523c975a12fc6e9e882068686dd895a 100644

--- a/components/pdf/renderer/pdf_accessibility_tree.cc

+++ b/components/pdf/renderer/pdf_accessibility_tree.cc

@@ -275,7 +275,7 @@ ui::AXNodeData* PdfAccessibilityTree::CreateNode(ui::AXRole role) {

ui::AXNodeData* node = new ui::AXNodeData();

node->id = render_accessibility->GenerateAXID();

node->role = role;

- node->state = 1 << ui::AX_STATE_READ_ONLY;

+ node->AddState(ui::AX_STATE_READ_ONLY);

// All nodes other than the first one have coordinates relative to

// the first node.