chrome/browser/ui/views/toolbar/toolbar_button.cc - Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_button.cc

Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData. (Closed)

Patch Set: Delete AXNodeData::Init() and clear bitfields in AXNodeData() instead. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/toolbar_button.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_button.cc b/chrome/browser/ui/views/toolbar/toolbar_button.cc

index 359d8216f84b545cb8ae6c4309cc2851526f0b83..83bf10e9c38fca320a550cd85a19cf3f13b71356 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_button.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_button.cc

@@ -130,7 +130,7 @@ void ToolbarButton::OnGestureEvent(ui::GestureEvent* event) {

void ToolbarButton::GetAccessibleNodeData(ui::AXNodeData* node_data) {

CustomButton::GetAccessibleNodeData(node_data);

node_data->role = ui::AX_ROLE_BUTTON_DROP_DOWN;

- node_data->AddStateFlag(ui::AX_STATE_HASPOPUP);

+ node_data->AddState(ui::AX_STATE_HASPOPUP);

if (enabled()) {

node_data->AddIntAttribute(ui::AX_ATTR_ACTION,

ui::AX_SUPPORTED_ACTION_PRESS);