A11y: Add/refactor methods for manipulating bitfields on AXNodeData.

ui/accessibility/ax_node_data.h

Index: ui/accessibility/ax_node_data.h
diff --git a/ui/accessibility/ax_node_data.h b/ui/accessibility/ax_node_data.h
index f44024f79c157e04d18093e0e824e4026cdac0ef..8be60eb349748e89d5c21ea82c44a128c8684d88 100644
--- a/ui/accessibility/ax_node_data.h
+++ b/ui/accessibility/ax_node_data.h
@@ -106,12 +106,11 @@ struct AX_EXPORT AXNodeData {
   void SetValue(const std::string& value);
   void SetValue(const base::string16& value);
 
-  // Helper to check whether |state_flag| is set in the given |state|.
-  static bool IsFlagSet(uint32_t state, ui::AXState state_flag);
-
-  // Set or check bits in |state_|.
-  void AddStateFlag(ui::AXState state_flag);
-  bool HasStateFlag(ui::AXState state_flag) const;
+  // Clear all bits in preparation for use of AXNodeData.
+  void Init();

[dmazzoni, 2017/05/08 04:28:26]

Perhaps we should just put this in the constructor?

A long time ago, I left state_ initialized to a bogus value purely
as a means to make sure that it was always being set deliberately
and not forgotten.

I think it may no longer be a good idea. All of these calls to Init()
are just a distraction, it would be much cleaner to just allow creating
an AXNodeData and having |state| set to a reasonable default.

Totally fine to just do that in this patch, or in a separate patch.

[Patti Lor, 2017/05/08 07:44:47]

I've deleted this Init() method and just set |state| to 0 in the constructor.

+  // Set or check bits in |state|.
+  bool HasState(ui::AXState state_flag) const;
+  void AddState(ui::AXState state_flag);
 
   // Return a string representation of this data, for debugging.
   virtual std::string ToString() const;