A11y: Add/refactor methods for manipulating bitfields on AXNodeData.

ui/accessibility/ax_node_data.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_ACCESSIBILITY_AX_NODE_DATA_H_
 #define UI_ACCESSIBILITY_AX_NODE_DATA_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 88 matching lines @@
                            const std::vector<int32_t>& value);
 
   // Convenience functions, mainly for writing unit tests.
   // Equivalent to AddStringAttribute(ATTR_NAME, name).
   void SetName(const std::string& name);
   void SetName(const base::string16& name);
   // Equivalent to AddStringAttribute(ATTR_VALUE, value).
   void SetValue(const std::string& value);
   void SetValue(const base::string16& value);
 
-  // Helper to check whether |state_flag| is set in the given |state|.
-  static bool IsFlagSet(uint32_t state, ui::AXState state_flag);
-
-  // Set or check bits in |state_|.
-  void AddStateFlag(ui::AXState state_flag);
-  bool HasStateFlag(ui::AXState state_flag) const;
+  // Clear all bits in preparation for use of AXNodeData.
+  void Init();

[dmazzoni, 2017/05/08 04:28:26]

Perhaps we should just put this in the constructor?

A long time ago, I left state_ initialized to a bogus value purely
as a means to make sure that it was always being set deliberately
and not forgotten.

I think it may no longer be a good idea. All of these calls to Init()
are just a distraction, it would be much cleaner to just allow creating
an AXNodeData and having |state| set to a reasonable default.

Totally fine to just do that in this patch, or in a separate patch.

[Patti Lor, 2017/05/08 07:44:47]

I've deleted this Init() method and just set |state| to 0 in the constructor.

+  // Set or check bits in |state|.
+  bool HasState(ui::AXState state_flag) const;
+  void AddState(ui::AXState state_flag);
 
   // Return a string representation of this data, for debugging.
   virtual std::string ToString() const;
 
   // As much as possible this should behave as a simple, serializable,
   // copyable struct.
   int32_t id;
   AXRole role;
   uint32_t state;
   std::vector<std::pair<AXStringAttribute, std::string>> string_attributes;
@@ skipping 19 matching lines @@
   // NOTE: this member is a std::unique_ptr because it's rare and gfx::Transform
   // takes up a fair amount of space. The assignment operator and copy
   // constructor both make a duplicate of the owned pointer, so it acts more
   // like a member than a pointer.
   std::unique_ptr<gfx::Transform> transform;
 };
 
 }  // namespace ui
 
 #endif  // UI_ACCESSIBILITY_AX_NODE_DATA_H_