Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2860873002: Notification API throws when serializing SharedArrayBuffer (Closed)

Created:
3 years, 7 months ago by binji
Modified:
3 years, 7 months ago
Reviewers:
Peter Beverloo
CC:
awdf+watch_chromium.org, blink-reviews, chromium-reviews, haraken, Peter Beverloo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/notifications/NotificationData.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
binji
3 years, 7 months ago (2017-05-03 22:22:48 UTC) #4
Peter Beverloo
lgtm Looking at V8ScriptValueSerializer, this flag is only used for shared arrag buffers, so that ...
3 years, 7 months ago (2017-05-03 22:35:49 UTC) #5
binji
On 2017/05/03 at 22:35:49, peter wrote: > lgtm > > Looking at V8ScriptValueSerializer, this flag ...
3 years, 7 months ago (2017-05-03 22:39:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860873002/1
3 years, 7 months ago (2017-05-03 23:33:14 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 01:11:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fd0cc89538d0cacf1d4f225e0e60...

Powered by Google App Engine
This is Rietveld 408576698