Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2860853003: Add tests for VerifyCertificateChain() when the last certificate is not (Closed)

Created:
3 years, 7 months ago by eroman
Modified:
3 years, 7 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for VerifyCertificateChain() when the last certificate is not trusted. Review-Url: https://codereview.chromium.org/2860853003 Cr-Commit-Position: refs/heads/master@{#469421} Committed: https://chromium.googlesource.com/chromium/src/+/d1c9c9bd63a09542c248a5595d87a17d58c8c4e4

Patch Set 1 #

Patch Set 2 : update for ios #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M net/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/cert/internal/verify_certificate_chain.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/cert/internal/verify_certificate_chain_typed_unittest.h View 2 chunks +6 lines, -0 lines 0 comments Download
A net/data/verify_certificate_chain_unittest/target-and-intermediate/distrusted-root.test View 1 chunk +8 lines, -0 lines 0 comments Download
A net/data/verify_certificate_chain_unittest/target-and-intermediate/unspecified-trust-root.test View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
eroman
3 years, 7 months ago (2017-05-04 02:18:32 UTC) #4
mattm
unwrap description (first line should be a complete sentence) lgtm
3 years, 7 months ago (2017-05-04 02:34:09 UTC) #5
eroman
Done (unwrapped description)
3 years, 7 months ago (2017-05-04 16:40:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860853003/10005
3 years, 7 months ago (2017-05-04 17:45:01 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 19:24:00 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:10005) as
https://chromium.googlesource.com/chromium/src/+/d1c9c9bd63a09542c248a5595d87...

Powered by Google App Engine
This is Rietveld 408576698