Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2860843003: Introduce a handlified version of source position iterator. (Closed)

Created:
3 years, 7 months ago by Jarin
Modified:
3 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce a handlified version of source position iterator. This enables allocation in Turbofan's graph building (which is useful for taking code dependencies there). BUG=v8:6357 R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2860843003 Cr-Commit-Position: refs/heads/master@{#45089} Committed: https://chromium.googlesource.com/v8/v8/+/418926e0104b2b634f38876b5b274840decf8e46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/source-position-table.h View 2 chunks +13 lines, -2 lines 0 comments Download
M src/source-position-table.cc View 1 chunk +13 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jarin
Could you take a look, please?
3 years, 7 months ago (2017-05-04 11:13:12 UTC) #1
Benedikt Meurer
LGTM
3 years, 7 months ago (2017-05-04 11:24:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860843003/1
3 years, 7 months ago (2017-05-04 11:26:54 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 12:34:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/418926e0104b2b634f38876b5b274840dec...

Powered by Google App Engine
This is Rietveld 408576698