Chromium Code Reviews

Issue 2860753003: [heap] Report newly found wrappers after deserialization (Closed)

Created:
3 years, 7 months ago by Michael Lippautz
Modified:
3 years, 7 months ago
Reviewers:
Hannes Payer (out of office)
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Report newly found wrappers after deserialization These wrappers wouldn't be found by the marker otherwise and are only reported upon the next marking step or GC which potentially is already too late; the embedder could've reclaimed those objects already. BUG=chromium:717480 Review-Url: https://codereview.chromium.org/2860753003 Cr-Commit-Position: refs/heads/master@{#45094} Committed: https://chromium.googlesource.com/v8/v8/+/2ec36b675e16693891986c10665b0e126defa10e

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+3 lines, -0 lines)
M src/heap/heap.cc View 1 chunk +3 lines, -0 lines 0 comments

Messages

Total messages: 13 (9 generated)
Michael Lippautz
ptal; we already have DCHECKs that there are no cached wrappers left behind and I ...
3 years, 7 months ago (2017-05-03 16:40:35 UTC) #3
Hannes Payer (out of office)
lgtm
3 years, 7 months ago (2017-05-04 12:46:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860753003/1
3 years, 7 months ago (2017-05-04 13:08:39 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 13:10:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2ec36b675e16693891986c10665b0e126de...

Powered by Google App Engine