Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2860753002: Remove disabling of reference builds on V8 benchmarks (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
Reviewers:
ulan, mythria
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove disabling of reference builds on V8 benchmarks Now that we ignore the return code of reference benchmarks run, there is no need to disabling these benchmarks on reference build. BUG=707237 Review-Url: https://codereview.chromium.org/2860753002 Cr-Commit-Position: refs/heads/master@{#469120} Committed: https://chromium.googlesource.com/chromium/src/+/0af024d53ed6e1ad7759ed5423ef6f98a9c7f6af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M tools/perf/benchmarks/v8_browsing.py View 7 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nednguyen
3 years, 7 months ago (2017-05-03 15:16:12 UTC) #2
ulan
lgtm
3 years, 7 months ago (2017-05-03 19:58:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860753002/1
3 years, 7 months ago (2017-05-03 19:59:43 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 21:08:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0af024d53ed6e1ad7759ed5423ef...

Powered by Google App Engine
This is Rietveld 408576698