Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2860743004: Disable inheritance propagation for text-align. (Closed)

Created:
3 years, 7 months ago by rune
Modified:
3 years, 7 months ago
Reviewers:
nainar, ktyliu
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable inheritance propagation for text-align. The text-align property has an internal value -webkit-match-parent with a dependency on the parent computed style used in the UA sheet for LI, which means the independent inheritance optimization won't work. R=ktyliu@chromium.org,nainar@chromium.org BUG=716797 Review-Url: https://codereview.chromium.org/2860743004 Cr-Commit-Position: refs/heads/master@{#469609} Committed: https://chromium.googlesource.com/chromium/src/+/be16e0bd842e5f7c1d62211f95e04ba41d2c3e11

Patch Set 1 #

Patch Set 2 : Fixed test expectation. #

Messages

Total messages: 15 (11 generated)
rune
ptal
3 years, 7 months ago (2017-05-04 12:44:48 UTC) #2
nainar
lgtm. FYI: ktyliu@ doesn't work on Chromium anymore.
3 years, 7 months ago (2017-05-05 00:54:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860743004/20001
3 years, 7 months ago (2017-05-05 07:07:24 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 07:11:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/be16e0bd842e5f7c1d62211f95e0...

Powered by Google App Engine
This is Rietveld 408576698