Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2860713002: Change the constraint to anchor constraints in GoogleLandingController (Closed)

Created:
3 years, 7 months ago by gambard
Modified:
3 years, 7 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the constraint to anchor constraints in GoogleLandingController The anchor constraints syntax is clearer than the old NSLayoutConstraint syntax. BUG=717974 Review-Url: https://codereview.chromium.org/2860713002 Cr-Commit-Position: refs/heads/master@{#469343} Committed: https://chromium.googlesource.com/chromium/src/+/808626a965952b3b50656b1fc57f995964506ec3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -76 lines) Patch
M ios/chrome/browser/ui/ntp/google_landing_view_controller.mm View 1 2 2 chunks +31 lines, -76 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
gambard
PTAL: jif@ for constraints, marq@ as owners. I will do another CL moving them to ...
3 years, 7 months ago (2017-05-03 13:09:23 UTC) #2
jif
lgtm https://codereview.chromium.org/2860713002/diff/1/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm File ios/chrome/browser/ui/ntp/google_landing_view_controller.mm (right): https://codereview.chromium.org/2860713002/diff/1/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm#newcode463 ios/chrome/browser/ui/ntp/google_landing_view_controller.mm:463: constraintEqualToConstant:kVoiceSearchButtonWidth], Nit: Make the width equal to kVoiceSearchButtonWidth, ...
3 years, 7 months ago (2017-05-03 13:21:08 UTC) #3
gambard
Thanks! https://codereview.chromium.org/2860713002/diff/1/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm File ios/chrome/browser/ui/ntp/google_landing_view_controller.mm (right): https://codereview.chromium.org/2860713002/diff/1/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm#newcode463 ios/chrome/browser/ui/ntp/google_landing_view_controller.mm:463: constraintEqualToConstant:kVoiceSearchButtonWidth], On 2017/05/03 13:21:08, jif wrote: > Nit: ...
3 years, 7 months ago (2017-05-03 13:25:04 UTC) #4
marq (ping after 24h)
lgtm
3 years, 7 months ago (2017-05-03 13:29:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860713002/40001
3 years, 7 months ago (2017-05-04 15:16:40 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 15:28:17 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/808626a965952b3b50656b1fc57f...

Powered by Google App Engine
This is Rietveld 408576698