Change the constraint to anchor constraints in GoogleLandingController

Change the constraint to anchor constraints in GoogleLandingController

The anchor constraints syntax is clearer than the old NSLayoutConstraint syntax.

BUG=717974
Review-Url: https://codereview.chromium.org/2860713002
Cr-Commit-Position: refs/heads/master@{#469343}
Committed: https://chromium.googlesource.com/chromium/src/+/808626a965952b3b50656b1fc57f995964506ec3

[gambard, 2017-05-03 13:09:22]

gambard@chromium.org changed reviewers:
+ jif@chromium.org, marq@chromium.org

[gambard, 2017-05-03 13:09:23]

PTAL: jif@ for constraints, marq@ as owners.
I will do another CL moving them to a helper.

[jif, 2017-05-03 13:21:08]

lgtm

https://codereview.chromium.org/2860713002/diff/1/ios/chrome/browser/ui/ntp/g...
File ios/chrome/browser/ui/ntp/google_landing_view_controller.mm (right):

https://codereview.chromium.org/2860713002/diff/1/ios/chrome/browser/ui/ntp/g...
ios/chrome/browser/ui/ntp/google_landing_view_controller.mm:463:
constraintEqualToConstant:kVoiceSearchButtonWidth],
Nit:
Make the width equal to kVoiceSearchButtonWidth, and make the height equal to
the width.
Or rename the constant to kVoiceSearchButtonHeight.

[gambard, 2017-05-03 13:25:04]

Thanks!

https://codereview.chromium.org/2860713002/diff/1/ios/chrome/browser/ui/ntp/g...
File ios/chrome/browser/ui/ntp/google_landing_view_controller.mm (right):

https://codereview.chromium.org/2860713002/diff/1/ios/chrome/browser/ui/ntp/g...
ios/chrome/browser/ui/ntp/google_landing_view_controller.mm:463:
constraintEqualToConstant:kVoiceSearchButtonWidth],
On 2017/05/03 13:21:08, jif wrote:
> Nit:
> Make the width equal to kVoiceSearchButtonWidth, and make the height equal to
> the width.
> Or rename the constant to kVoiceSearchButtonHeight.

Done.

[gambard, 2017-05-03 13:25:08]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 13:25:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marq (ping after 24h), 2017-05-03 13:29:08]

lgtm

[commit-bot: I haz the power, 2017-05-03 14:32:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 14:32:30]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[gambard, 2017-05-04 15:16:20]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-05-04 15:16:20]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org,
marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2860713002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-04 15:16:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 15:28:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493910980491950,
"parent_rev": "1296202771665ed3ecd53b31c16391258933cb08", "commit_rev":
"808626a965952b3b50656b1fc57f995964506ec3"}

[commit-bot: I haz the power, 2017-05-04 15:28:16]

Description was changed from

==========
Change the constraint to anchor constraints in GoogleLandingController

The anchor constraints syntax is clearer than the old NSLayoutConstraint syntax.

BUG=717974
==========

to

==========
Change the constraint to anchor constraints in GoogleLandingController

The anchor constraints syntax is clearer than the old NSLayoutConstraint syntax.

BUG=717974

Review-Url: https://codereview.chromium.org/2860713002
Cr-Commit-Position: refs/heads/master@{#469343}
Committed:
https://chromium.googlesource.com/chromium/src/+/808626a965952b3b50656b1fc57f...
==========

[commit-bot: I haz the power, 2017-05-04 15:28:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/808626a965952b3b50656b1fc57f...