Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2860673004: Remove unused code in runner.js (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused code in runner.js BUG=701059 Review-Url: https://codereview.chromium.org/2860673004 Cr-Commit-Position: refs/heads/master@{#469069} Committed: https://chromium.googlesource.com/chromium/src/+/ed0baf9d5229f2869c8a909bc5761f21fd0a6eac

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/PerformanceTests/resources/runner.js View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 11 (7 generated)
nednguyen
https://codereview.chromium.org/2860673004/diff/1/third_party/WebKit/PerformanceTests/resources/runner.js File third_party/WebKit/PerformanceTests/resources/runner.js (left): https://codereview.chromium.org/2860673004/diff/1/third_party/WebKit/PerformanceTests/resources/runner.js#oldcode175 third_party/WebKit/PerformanceTests/resources/runner.js:175: window.testRunner.traceEventsToMeasure = test.traceEventsToMeasure; This was mistakenly left out when ...
3 years, 7 months ago (2017-05-03 16:29:18 UTC) #2
Xianzhu
lgtm
3 years, 7 months ago (2017-05-03 16:30:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860673004/1
3 years, 7 months ago (2017-05-03 16:35:04 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 19:23:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ed0baf9d5229f2869c8a909bc576...

Powered by Google App Engine
This is Rietveld 408576698