third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp - Issue 2860673002: Change all test cases to use WebViewBase instead of WebViewImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp

Issue 2860673002: Change all test cases to use WebViewBase instead of WebViewImpl. (Closed)

Patch Set: Address code review comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp b/third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp

index ba05255542f562bbf5df9e073cc421904e0605be..ccd9415c89e5ec5025cbb223d7992660433698c9 100644

--- a/third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp

+++ b/third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp

@@ -170,7 +170,7 @@ TEST_F(DocumentLoaderTest, MultiChunkWithReentrancy) {

}

TEST_F(DocumentLoaderTest, isCommittedButEmpty) {

- WebViewImpl* web_view_impl =

+ WebViewBase* web_view_impl =

web_view_helper_.InitializeAndLoad("about:blank", true);

EXPECT_TRUE(ToLocalFrame(web_view_impl->GetPage()->MainFrame())

->Loader()