Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp

Issue 2860673002: Change all test cases to use WebViewBase instead of WebViewImpl. (Closed)
Patch Set: Address code review comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp b/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
index a18f92be7abaaffd70fd307e0a7357addf0fd2e3..0c0cf467b591bab2f0934e7739356ba321487bfb 100644
--- a/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
+++ b/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
@@ -44,7 +44,7 @@ class CompositorWorkerTest
void SetUp() override {
helper_.Initialize(true, nullptr, &mock_web_view_client_, nullptr,
&ConfigureSettings);
- GetWebViewImpl()->Resize(IntSize(320, 240));
+ GetWebView()->Resize(IntSize(320, 240));
}
~CompositorWorkerTest() override {
@@ -54,12 +54,11 @@ class CompositorWorkerTest
}
void NavigateTo(const String& url) {
- FrameTestHelpers::LoadFrame(GetWebViewImpl()->MainFrame(),
- url.Utf8().data());
+ FrameTestHelpers::LoadFrame(GetWebView()->MainFrame(), url.Utf8().data());
}
void ForceFullCompositingUpdate() {
- GetWebViewImpl()->UpdateAllLifecyclePhases();
+ GetWebView()->UpdateAllLifecyclePhases();
}
void RegisterMockedHttpURLLoad(const std::string& file_name) {
@@ -91,7 +90,7 @@ class CompositorWorkerTest
return web_scroll_layer;
}
- WebViewImpl* GetWebViewImpl() const { return helper_.WebView(); }
+ WebViewBase* GetWebView() const { return helper_.WebView(); }
LocalFrame* GetFrame() const {
return helper_.WebView()->MainFrameImpl()->GetFrame();
}

Powered by Google App Engine
This is Rietveld 408576698