Make CWS Report Abuse page the active tab after report abuse and uninstall

chrome/browser/extensions/extension_uninstall_dialog.h

Index: chrome/browser/extensions/extension_uninstall_dialog.h
diff --git a/chrome/browser/extensions/extension_uninstall_dialog.h b/chrome/browser/extensions/extension_uninstall_dialog.h
index 384bd8e9212cdf1b258792a9e61af608c4696fda..d3569cac0373b78d01cd4b79388a9a99a7b656a2 100644
--- a/chrome/browser/extensions/extension_uninstall_dialog.h
+++ b/chrome/browser/extensions/extension_uninstall_dialog.h
@@ -95,6 +95,9 @@ class ExtensionUninstallDialog
   const gfx::ImageSkia& icon() const { return icon_; }
 
  private:
+  // Uninstalls the extension.
+  void Uninstall(bool& success, base::string16& error);

[Devlin, 2017/05/05 20:46:38]

two notes:
- We shouldn't pass POD (like bool) by reference
- Arguments passed by reference should be const &; if the value needs to be
changed (as in this case), they should be passed by pointer (*).

[catmullings, 2017/05/15 22:27:55]

What does POD mean?

[Devlin, 2017/05/15 23:28:04]

POD refers to "Plain Old Data", and basically means any raw c-type.  These types
don't have constructors, destructors, members, methods, etc, and the footprint
in memory is roughly the same as a pointer or reference.  For instance, an int
takes up 32 - 64 bits in memory, so passing it by reference is actually no
cheaper than copying the data, since the reference itself also takes up 32 - 64
bits in memory.  Additionally, passing by references has drawbacks of
potentially mutating it without intending to.  As a result, we should only pass
POD types (like bool, int, and char) by value or by pointer (by pointer when we
expect it to either be null or to be mutated).  (Other codebases could also
allow by reference in the case that we mutate it, but that's disallowed in
chromium.)

[catmullings, 2017/05/18 18:25:59]

Done.

+
   // Handles the "report abuse" checkbox being checked at the close of the
   // dialog.
   void HandleReportAbuse();