Make CWS Report Abuse page the active tab after report abuse and uninstall

chrome/browser/extensions/extension_uninstall_dialog.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_UNINSTALL_DIALOG_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_UNINSTALL_DIALOG_H_
 
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
@@ skipping 77 matching lines @@
 
   // Accessors for members.
   const Profile* profile() const { return profile_; }
   Delegate* delegate() const { return delegate_; }
   const Extension* extension() const { return extension_.get(); }
   const Extension* triggering_extension() const {
       return triggering_extension_.get(); }
   const gfx::ImageSkia& icon() const { return icon_; }
 
  private:
+  // Uninstalls the extension.
+  void Uninstall(bool& success, base::string16& error);

[Devlin, 2017/05/05 20:46:38]

two notes:
- We shouldn't pass POD (like bool) by reference
- Arguments passed by reference should be const &; if the value needs to be
changed (as in this case), they should be passed by pointer (*).

[catmullings, 2017/05/15 22:27:55]

What does POD mean?

[Devlin, 2017/05/15 23:28:04]

POD refers to "Plain Old Data", and basically means any raw c-type.  These types
don't have constructors, destructors, members, methods, etc, and the footprint
in memory is roughly the same as a pointer or reference.  For instance, an int
takes up 32 - 64 bits in memory, so passing it by reference is actually no
cheaper than copying the data, since the reference itself also takes up 32 - 64
bits in memory.  Additionally, passing by references has drawbacks of
potentially mutating it without intending to.  As a result, we should only pass
POD types (like bool, int, and char) by value or by pointer (by pointer when we
expect it to either be null or to be mutated).  (Other codebases could also
allow by reference in the case that we mutate it, but that's disallowed in
chromium.)

[catmullings, 2017/05/18 18:25:59]

Done.

+
   // Handles the "report abuse" checkbox being checked at the close of the
   // dialog.
   void HandleReportAbuse();
 
   // Sets the icon that will be used in the dialog. If |icon| contains an empty
   // image, then we use a default icon instead.
   void SetIcon(const gfx::Image& image);
 
   void OnImageLoaded(const std::string& extension_id, const gfx::Image& image);
 
@@ skipping 19 matching lines @@
   UninstallReason uninstall_reason_;
 
   base::ThreadChecker thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionUninstallDialog);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_UNINSTALL_DIALOG_H_