Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2860653002: Use new sanitizer coverage flags. (Closed)

Created:
3 years, 7 months ago by Oliver Chang
Modified:
3 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Use new sanitizer coverage flags. -fsanitize-coverage={edge,bb,func} are deprecated. -fsanitize-coverage={edge,bb,func},trace-pc-guard should be used instead (edge is default). BUG=chromium:651540 Review-Url: https://codereview.chromium.org/2860653002 Cr-Commit-Position: refs/heads/master@{#45072} Committed: https://chromium.googlesource.com/v8/v8/+/644379eedc8d0442e92e7a7713dcfe490d5c214b

Patch Set 1 #

Patch Set 2 : one more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M gypfiles/coverage_wrapper.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M infra/mb/mb_config.pyl View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/testrunner/testrunner.isolate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Oliver Chang
PTAL
3 years, 7 months ago (2017-05-03 00:23:48 UTC) #4
Oliver Chang
On 2017/05/03 00:23:48, Oliver Chang wrote: > PTAL machenbach, friendly ping :)
3 years, 7 months ago (2017-05-03 16:36:18 UTC) #7
Michael Achenbach
lgtm
3 years, 7 months ago (2017-05-03 18:44:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860653002/20001
3 years, 7 months ago (2017-05-03 18:57:01 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 19:36:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/644379eedc8d0442e92e7a7713dcfe490d5...

Powered by Google App Engine
This is Rietveld 408576698