Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2860643002: Use new sanitizer coverage flags. (Closed)

Created:
3 years, 7 months ago by Oliver Chang
Modified:
3 years, 7 months ago
Reviewers:
mithro
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use new sanitizer coverage flags. -fsanitize-coverage={edge,bb,func} are deprecated. -fsanitize-coverage={edge,bb,func},trace-pc-guard should be used instead (edge is default). BUG=651540 Review-Url: https://codereview.chromium.org/2860643002 Cr-Commit-Position: refs/heads/master@{#468993} Committed: https://chromium.googlesource.com/chromium/src/+/b966abcf92859d9600ceddf8d90b2caa832c7a6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M build/config/sanitizers/sanitizers.gni View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Oliver Chang
tansell, PTAL at the mb_config.pyl change. thanks!
3 years, 7 months ago (2017-05-02 23:31:31 UTC) #3
mithro
LGTM But I don't think I'm OWNERery enough to let you submit this?
3 years, 7 months ago (2017-05-03 03:17:06 UTC) #10
mithro
(If I am, go ahead!)
3 years, 7 months ago (2017-05-03 03:17:47 UTC) #11
Oliver Chang
On 2017/05/03 03:17:06, mithro wrote: > LGTM But I don't think I'm OWNERery enough to ...
3 years, 7 months ago (2017-05-03 03:18:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860643002/1
3 years, 7 months ago (2017-05-03 16:01:01 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 16:06:07 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b966abcf92859d9600ceddf8d90b...

Powered by Google App Engine
This is Rietveld 408576698