Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2860603002:
Import Geolocation and Vibration web-platform-tests (Closed)
DescriptionImport Geolocation and Vibration web-platform-tests
BUG=711032
Review-Url: https://codereview.chromium.org/2860603002
Cr-Commit-Position: refs/heads/master@{#469634}
Committed: https://chromium.googlesource.com/chromium/src/+/9924ab42f638a24c64ec0dc9c450bf6bbf294e3a
Patch Set 1 #
Total comments: 2
Patch Set 2 : mcasas #Patch Set 3 : rebase #Messages
Total messages: 20 (9 generated)
mvanouwerkerk@chromium.org changed reviewers: + mcasas@chromium.org
https://codereview.chromium.org/2860603002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/2860603002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/W3CImportExpectations:271: ## Owners: mvanouwerkerk@chromium.org I think this should be mcasas@chromium.org now, I'll add him as a reviewer.
https://codereview.chromium.org/2860603002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/2860603002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/W3CImportExpectations:271: ## Owners: mvanouwerkerk@chromium.org On 2017/05/04 11:03:21, Michael van Ouwerkerk wrote: > I think this should be mailto:mcasas@chromium.org now, I'll add him as a reviewer. Switched to mcasas@
Description was changed from ========== Import Geolocation and Vibration web-platform-tests R=mvanouwerkerk@chromium.org ========== to ========== Import Geolocation and Vibration web-platform-tests ==========
On 2017/05/04 14:50:28, foolip wrote: > https://codereview.chromium.org/2860603002/diff/1/third_party/WebKit/LayoutTe... > File third_party/WebKit/LayoutTests/W3CImportExpectations (right): > > https://codereview.chromium.org/2860603002/diff/1/third_party/WebKit/LayoutTe... > third_party/WebKit/LayoutTests/W3CImportExpectations:271: ## Owners: > mailto:mvanouwerkerk@chromium.org > On 2017/05/04 11:03:21, Michael van Ouwerkerk wrote: > > I think this should be mailto:mcasas@chromium.org now, I'll add him as a > reviewer. > > Switched to mcasas@ This looks good to me but when I tried importing the geo tests I saw most of them failing due to peculiar use of done() and made a upstream PR to address it [1] but it somehow got stuck -- should we land this import anyway? I'll leave it to you, would be fine either way. Also, could you land this against https://crbug.com/711032 ? Thanks!! [1] https://github.com/w3c/web-platform-tests/pull/5559#issuecomment-294017928
Description was changed from ========== Import Geolocation and Vibration web-platform-tests ========== to ========== Import Geolocation and Vibration web-platform-tests BUG=711032 ==========
lgtm
On 2017/05/04 16:14:44, mcasas wrote: > On 2017/05/04 14:50:28, foolip wrote: > > > https://codereview.chromium.org/2860603002/diff/1/third_party/WebKit/LayoutTe... > > File third_party/WebKit/LayoutTests/W3CImportExpectations (right): > > > > > https://codereview.chromium.org/2860603002/diff/1/third_party/WebKit/LayoutTe... > > third_party/WebKit/LayoutTests/W3CImportExpectations:271: ## Owners: > > mailto:mvanouwerkerk@chromium.org > > On 2017/05/04 11:03:21, Michael van Ouwerkerk wrote: > > > I think this should be mailto:mcasas@chromium.org now, I'll add him as a > > reviewer. > > > > Switched to mcasas@ > > This looks good to me but when I tried importing the geo tests > I saw most of them failing due to peculiar use of done() and > made a upstream PR to address it [1] but it somehow got > stuck -- should we land this import anyway? I'll leave it to you, > would be fine either way. > > Also, could you land this against https://crbug.com/711032 ? > Thanks!! > > > [1] https://github.com/w3c/web-platform-tests/pull/5559#issuecomment-294017928 I've merged that PR now. Please LGTM and CQ if you're happy importing it now.
On 2017/05/05 11:10:51, foolip wrote: > On 2017/05/04 16:14:44, mcasas wrote: > > On 2017/05/04 14:50:28, foolip wrote: > > > > > > https://codereview.chromium.org/2860603002/diff/1/third_party/WebKit/LayoutTe... > > > File third_party/WebKit/LayoutTests/W3CImportExpectations (right): > > > > > > > > > https://codereview.chromium.org/2860603002/diff/1/third_party/WebKit/LayoutTe... > > > third_party/WebKit/LayoutTests/W3CImportExpectations:271: ## Owners: > > > mailto:mvanouwerkerk@chromium.org > > > On 2017/05/04 11:03:21, Michael van Ouwerkerk wrote: > > > > I think this should be mailto:mcasas@chromium.org now, I'll add him as a > > > reviewer. > > > > > > Switched to mcasas@ > > > > This looks good to me but when I tried importing the geo tests > > I saw most of them failing due to peculiar use of done() and > > made a upstream PR to address it [1] but it somehow got > > stuck -- should we land this import anyway? I'll leave it to you, > > would be fine either way. > > > > Also, could you land this against https://crbug.com/711032 ? > > Thanks!! > > > > > > [1] https://github.com/w3c/web-platform-tests/pull/5559#issuecomment-294017928 > > I've merged that PR now. Please LGTM and CQ if you're happy importing it now. Sorry, mid-air collision, I got my LGTM.
The CQ bit was checked by foolip@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by foolip@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mvanouwerkerk@chromium.org Link to the patchset: https://codereview.chromium.org/2860603002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493983569328680,
"parent_rev": "bcf1761cd4aeed7767caf8fd6f8188aa0e46728a", "commit_rev":
"9924ab42f638a24c64ec0dc9c450bf6bbf294e3a"}
Message was sent while issue was closed.
Description was changed from ========== Import Geolocation and Vibration web-platform-tests BUG=711032 ========== to ========== Import Geolocation and Vibration web-platform-tests BUG=711032 Review-Url: https://codereview.chromium.org/2860603002 Cr-Commit-Position: refs/heads/master@{#469634} Committed: https://chromium.googlesource.com/chromium/src/+/9924ab42f638a24c64ec0dc9c450... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/9924ab42f638a24c64ec0dc9c450... |
