Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2860573012: Updated stale generated class comment in CSSPropertyAPI.h (Closed)

Created:
3 years, 7 months ago by Bugs Nash
Modified:
3 years, 7 months ago
Reviewers:
Jia, Eric Willigers
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated stale generated class comment in CSSPropertyAPI.h Added note that not all property APIs implement all the methods. BUG=668012 Review-Url: https://codereview.chromium.org/2860573012 Cr-Commit-Position: refs/heads/master@{#469596} Committed: https://chromium.googlesource.com/chromium/src/+/6597730dd27c7207682ef6390f9388a83d56a702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPI.h.tmpl View 1 chunk +14 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Bugs Nash
3 years, 7 months ago (2017-05-05 01:26:02 UTC) #2
Jia
On 2017/05/05 01:26:02, Bugs Nash wrote: LGTM
3 years, 7 months ago (2017-05-05 01:33:25 UTC) #3
Bugs Nash
3 years, 7 months ago (2017-05-05 01:38:12 UTC) #5
Bugs Nash
+eric for committers
3 years, 7 months ago (2017-05-05 01:38:23 UTC) #6
Eric Willigers
lgtm
3 years, 7 months ago (2017-05-05 02:40:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860573012/1
3 years, 7 months ago (2017-05-05 03:07:19 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 04:44:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6597730dd27c7207682ef6390f93...

Powered by Google App Engine
This is Rietveld 408576698