Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2860573009: Use constexpr TaskTraits constructor in media. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
gab, hubbe
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use constexpr TaskTraits constructor in media. Use a constexpr constructor that accepts traits in any order instead of the builder pattern to construct TaskTraits in media. BUG=713683 R=gab@chromium.org TBR=hubbe@chromium.org Review-Url: https://codereview.chromium.org/2860573009 Cr-Commit-Position: refs/heads/master@{#469159} Committed: https://chromium.googlesource.com/chromium/src/+/e6baa90f9f21576ecd6f11980c81776af7ae0866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/filters/ffmpeg_demuxer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
fdoray
3 years, 7 months ago (2017-05-03 20:24:07 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
3 years, 7 months ago (2017-05-03 20:24:10 UTC) #3
hubbe
lgtm
3 years, 7 months ago (2017-05-03 20:28:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860573009/1
3 years, 7 months ago (2017-05-03 20:37:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860573009/1
3 years, 7 months ago (2017-05-03 20:44:04 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 22:09:41 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e6baa90f9f21576ecd6f11980c81...

Powered by Google App Engine
This is Rietveld 408576698