components/browsing_data/content/conditional_cache_counting_helper.cc - Issue 2860573004: [Offline Pages] Add cached offline page utils and show usage in settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browsing_data/content/conditional_cache_counting_helper.cc

Issue 2860573004: [Offline Pages] Add cached offline page utils and show usage in settings. (Closed)

Patch Set: address missed comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/browsing_data/content/conditional_cache_counting_helper.h ('k') | components/offline_pages/core/offline_page_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/browsing_data/content/conditional_cache_counting_helper.cc

diff --git a/components/browsing_data/content/conditional_cache_counting_helper.cc b/components/browsing_data/content/conditional_cache_counting_helper.cc

index 05f4f17d49349d700572e85499180940870b1c3c..3cbf8c7ac1621c9056faf0407e049cff0731587e 100644

--- a/components/browsing_data/content/conditional_cache_counting_helper.cc

+++ b/components/browsing_data/content/conditional_cache_counting_helper.cc

@@ -74,7 +74,7 @@ void ConditionalCacheCountingHelper::Finished() {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!is_finished_);

is_finished_ = true;

- result_callback_.Run(calculation_result_, is_upper_limit_);

+ result_callback_.Run(is_upper_limit_, calculation_result_);

base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);

}