components/browsing_data/content/conditional_cache_counting_helper.h - Issue 2860573004: [Offline Pages] Add cached offline page utils and show usage in settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browsing_data/content/conditional_cache_counting_helper.h

Issue 2860573004: [Offline Pages] Add cached offline page utils and show usage in settings. (Closed)

Patch Set: address missed comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc ('k') | components/browsing_data/content/conditional_cache_counting_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/browsing_data/content/conditional_cache_counting_helper.h

diff --git a/components/browsing_data/content/conditional_cache_counting_helper.h b/components/browsing_data/content/conditional_cache_counting_helper.h

index 5a071b78c6c32f3228679607527beffc3f6a29cf..0bca3f364783c88250d6cd34a26d9fe163522136 100644

--- a/components/browsing_data/content/conditional_cache_counting_helper.h

+++ b/components/browsing_data/content/conditional_cache_counting_helper.h

@@ -25,9 +25,9 @@ namespace browsing_data {

// Helper to count the size of the http cache data from a StoragePartition.

class ConditionalCacheCountingHelper {

public:

- // Returns the number bytes in the selected range and if this value is an

- // upper estimate.

- typedef base::Callback<void(int64_t, bool)> CacheCountCallback;

+ // Returns if this value is an upper estimate and the number bytes in the

+ // selected range.

+ typedef base::Callback<void(bool, int64_t)> CacheCountCallback;

static ConditionalCacheCountingHelper* CreateForRange(

content::StoragePartition* storage_partition,