Disables Native App Launcher functionality.

Disables Native App Launcher functionality.

This is the first step of deprecating Native App Launcher.
This puts the functionality behind an experimental flag
experimental_flags::IsNativeAppLauncherEnabled().
There will be lots of dead code and unused classes/methods left after
this step and they will be removed after experiment is removed.

Default for experiment is Native App Launcher *disabled*.

BUG=711511
TEST=Tools > Settings > Google Apps should not be there. Visits to Maps or YouTube sites will not show infobar. Tapping on Maps or YouTube links may still launch Maps and YouTube app because of Universal Links.

Review-Url: https://codereview.chromium.org/2860573003
Cr-Commit-Position: refs/heads/master@{#469207}
Committed: https://chromium.googlesource.com/chromium/src/+/659aad38059a5877a7aa467212db0f9d9a5f5fcc

[pkl (ping after 24h if needed), 2017-05-02 22:15:43]

pkl@chromium.org changed reviewers:
+ rohitrao@chromium.org

[pkl (ping after 24h if needed), 2017-05-02 22:15:44]

This is a reland of https://codereview.chromium.org/2821453003/ with
experimental switch to disable deprecation (i.e. enable) Native App Launcher.

[rohitrao (ping after 24h), 2017-05-03 22:53:07]

lgtm

https://codereview.chromium.org/2860573003/diff/1/ios/chrome/browser/tabs/tab.mm
File ios/chrome/browser/tabs/tab.mm (right):

https://codereview.chromium.org/2860573003/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab.mm:1555: // TODO(crbug/711511): If Native App
Launcher is not enabled, returning NO to
Remove "to"

https://codereview.chromium.org/2860573003/diff/1/ios/chrome/browser/ui/setti...
File ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
(right):

https://codereview.chromium.org/2860573003/diff/1/ios/chrome/browser/ui/setti...
ios/chrome/browser/ui/settings/settings_collection_view_controller.mm:363:
toSectionWithIdentifier:SectionIdentifierBasics];
I'm a little surprised that we don't have a unittest that checks that this item
is present.

[pkl (ping after 24h if needed), 2017-05-03 23:20:01]

Thanks!

https://codereview.chromium.org/2860573003/diff/1/ios/chrome/browser/tabs/tab.mm
File ios/chrome/browser/tabs/tab.mm (right):

https://codereview.chromium.org/2860573003/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab.mm:1555: // TODO(crbug/711511): If Native App
Launcher is not enabled, returning NO to
On 2017/05/03 22:53:07, rohitrao (ping after 24h) wrote:
> Remove "to"

Done.

https://codereview.chromium.org/2860573003/diff/1/ios/chrome/browser/ui/setti...
File ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
(right):

https://codereview.chromium.org/2860573003/diff/1/ios/chrome/browser/ui/setti...
ios/chrome/browser/ui/settings/settings_collection_view_controller.mm:363:
toSectionWithIdentifier:SectionIdentifierBasics];
On 2017/05/03 22:53:07, rohitrao (ping after 24h) wrote:
> I'm a little surprised that we don't have a unittest that checks that this
item
> is present.

You mean, you are surprised that we don't have *any* unit tests for this file?
;)

[pkl (ping after 24h if needed), 2017-05-03 23:20:57]

The CQ bit was checked by pkl@chromium.org

[pkl (ping after 24h if needed), 2017-05-03 23:20:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2860573003/#ps20001
(title: "fixed a comment")

[commit-bot: I haz the power, 2017-05-03 23:21:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 23:34:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 23:34:39]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[pkl (ping after 24h if needed), 2017-05-03 23:45:02]

The CQ bit was checked by pkl@chromium.org

[pkl (ping after 24h if needed), 2017-05-03 23:45:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2860573003/#ps40001
(title: "fixed egtests compilation")

[commit-bot: I haz the power, 2017-05-03 23:45:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 23:58:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493855102053160,
"parent_rev": "9c9853ec9c2a166dc204e64595708202c48dcf26", "commit_rev":
"659aad38059a5877a7aa467212db0f9d9a5f5fcc"}

[commit-bot: I haz the power, 2017-05-03 23:58:16]

Description was changed from

==========
Disables Native App Launcher functionality.

This is the first step of deprecating Native App Launcher.
This puts the functionality behind an experimental flag
experimental_flags::IsNativeAppLauncherEnabled().
There will be lots of dead code and unused classes/methods left after
this step and they will be removed after experiment is removed.

Default for experiment is Native App Launcher *disabled*.

BUG=711511
TEST=Tools > Settings > Google Apps should not be there. Visits to Maps or
YouTube sites will not show infobar. Tapping on Maps or YouTube links may still
launch Maps and YouTube app because of Universal Links.
==========

to

==========
Disables Native App Launcher functionality.

This is the first step of deprecating Native App Launcher.
This puts the functionality behind an experimental flag
experimental_flags::IsNativeAppLauncherEnabled().
There will be lots of dead code and unused classes/methods left after
this step and they will be removed after experiment is removed.

Default for experiment is Native App Launcher *disabled*.

BUG=711511
TEST=Tools > Settings > Google Apps should not be there. Visits to Maps or
YouTube sites will not show infobar. Tapping on Maps or YouTube links may still
launch Maps and YouTube app because of Universal Links.

Review-Url: https://codereview.chromium.org/2860573003
Cr-Commit-Position: refs/heads/master@{#469207}
Committed:
https://chromium.googlesource.com/chromium/src/+/659aad38059a5877a7aa467212db...
==========

[commit-bot: I haz the power, 2017-05-03 23:58:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/659aad38059a5877a7aa467212db...