Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2860573002: Remove Chromium-specific code from WPT tests (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, falken+watch_chromium.org, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, shimazu+serviceworker_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Chromium-specific code from WPT tests This logic is no longer necessary and may therefore be removed. BUG=688116 R=mek@chromium.org Review-Url: https://codereview.chromium.org/2860573002 Cr-Commit-Position: refs/heads/master@{#469676} Committed: https://chromium.googlesource.com/chromium/src/+/458895e81b69730ca8db6e4432db73631cbd783f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-mixed-content-to-inscope.https.html View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-mixed-content-to-outscope.https.html View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
mike3
I believe this logic to be unnecessary because it has not effected my local testing ...
3 years, 7 months ago (2017-05-02 21:49:38 UTC) #1
Marijn Kruisselbrink
lgtm
3 years, 7 months ago (2017-05-03 22:55:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860573002/1
3 years, 7 months ago (2017-05-05 15:16:47 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 16:30:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/458895e81b69730ca8db6e4432db...

Powered by Google App Engine
This is Rietveld 408576698