[Payments] Make AutofillPaymentInstrumentTest use test objects

[Payments] Make AutofillPaymentInstrumentTest use test objects.

Now uses test normalizer and delegate.
BUG=None
TEST=existing

Review-Url: https://codereview.chromium.org/2860563002
Cr-Commit-Position: refs/heads/master@{#468990}
Committed: https://chromium.googlesource.com/chromium/src/+/d69786293ebcd67df21ae765560289dfc065eb6d

[sebsg, 2017-05-02 21:13:54]

sebsg@chromium.org changed reviewers:
+ mathp@chromium.org

[sebsg, 2017-05-02 21:13:54]

Hi Math, PTAL?

[Mathieu, 2017-05-03 02:07:29]

Description was changed from

==========
[Payments] Make AutofillInstrumentTest use test normalizer and delegate.

BUG=
==========

to

==========
[Payments] Make AutofillPaymentInstrumentTest use test objects.

Now uses test normalizer and delegate.
BUG=None
TEST=existing
==========

[Mathieu, 2017-05-03 02:12:48]

lgtm

https://codereview.chromium.org/2860563002/diff/1/components/payments/core/te...
File components/payments/core/test_payment_request_delegate.h (right):

https://codereview.chromium.org/2860563002/diff/1/components/payments/core/te...
components/payments/core/test_payment_request_delegate.h:35:
TestAddressNormalizer* GetTestAddressNormalizer();
test_address_normalizer()?

https://codereview.chromium.org/2860563002/diff/1/components/payments/core/te...
components/payments/core/test_payment_request_delegate.h:37: void
CompleteFullCardRequest();
I don't see where this is used?

[sebsg, 2017-05-03 15:14:47]

Thanks, sending to CQ

https://codereview.chromium.org/2860563002/diff/1/components/payments/core/te...
File components/payments/core/test_payment_request_delegate.h (right):

https://codereview.chromium.org/2860563002/diff/1/components/payments/core/te...
components/payments/core/test_payment_request_delegate.h:35:
TestAddressNormalizer* GetTestAddressNormalizer();
On 2017/05/03 02:12:48, Mathieu wrote:
> test_address_normalizer()?

Done.

https://codereview.chromium.org/2860563002/diff/1/components/payments/core/te...
components/payments/core/test_payment_request_delegate.h:37: void
CompleteFullCardRequest();
On 2017/05/03 02:12:48, Mathieu wrote:
> I don't see where this is used?

It's used in 2 places at the moment:

https://cs.chromium.org/chromium/src/components/payments/core/autofill_paymen...

https://cs.chromium.org/chromium/src/components/payments/core/autofill_paymen...

[sebsg, 2017-05-03 15:14:50]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2017-05-03 15:14:50]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2860563002/#ps20001
(title: "Addressed comment")

[commit-bot: I haz the power, 2017-05-03 15:15:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 15:57:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493824490213620,
"parent_rev": "51966e62c532574324c8fe6f6745ceb47160d241", "commit_rev":
"d69786293ebcd67df21ae765560289dfc065eb6d"}

[commit-bot: I haz the power, 2017-05-03 15:57:47]

Description was changed from

==========
[Payments] Make AutofillPaymentInstrumentTest use test objects.

Now uses test normalizer and delegate.
BUG=None
TEST=existing
==========

to

==========
[Payments] Make AutofillPaymentInstrumentTest use test objects.

Now uses test normalizer and delegate.
BUG=None
TEST=existing

Review-Url: https://codereview.chromium.org/2860563002
Cr-Commit-Position: refs/heads/master@{#468990}
Committed:
https://chromium.googlesource.com/chromium/src/+/d69786293ebcd67df21ae7655602...
==========

[commit-bot: I haz the power, 2017-05-03 15:57:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d69786293ebcd67df21ae7655602...