Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: ash/public/interfaces/shelf.mojom

Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings. (Closed)
Patch Set: Fix struct traits typo. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/public/cpp/window_properties.cc ('k') | ash/shelf/app_list_shelf_item_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/public/interfaces/shelf.mojom
diff --git a/ash/public/interfaces/shelf.mojom b/ash/public/interfaces/shelf.mojom
index 19e0c2213a1422f3419d76cde8912a93af6a60c8..10127072e8934aa5737e124cc0ed9ba2eb746219 100644
--- a/ash/public/interfaces/shelf.mojom
+++ b/ash/public/interfaces/shelf.mojom
@@ -115,16 +115,22 @@ struct MenuItem {
uint32 radio_group_id; // The radio group id.
};
+// Identifier for shelf items and their windows.
+// This structure matches ash::ShelfID.
+struct ShelfID {
+ string app_id; // An app id string, used to match app windows.
+ // (eg. extension ids, arc ids, "AppList", etc.)
+ string launch_id; // A string used to support multiple items per app.
+ // (eg. Citrix may use 'Word' or 'Excel' launch ids)
+};
+
// ShelfItems are used to populate the shelf.
// This structure matches ash::ShelfItem.
struct ShelfItem {
ShelfItemType type; // The type of the shelf item.
skia.mojom.Bitmap image; // An icon image Bitmap, shown on the shelf.
- int64 shelf_id; // A shelf model ID used by the shelf and clients.
ShelfItemStatus status; // The running/closed/etc. status of the item.
- string app_id; // An app id string, used to match app windows.
- string launch_id; // A string used to support multiple items per app.
- // (eg. Citrix may use 'Word' or 'Excel' launch ids)
+ ShelfID shelf_id; // The id for the shelf item and its windows.
mojo.common.mojom.String16 title; // The title to display for tooltips, etc.
bool shows_tooltip; // Whether the tooltip should be shown on hover.
bool pinned_by_policy; // Whether the item is pinned by policy preferences,
« no previous file with comments | « ash/public/cpp/window_properties.cc ('k') | ash/shelf/app_list_shelf_item_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698