Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: ash/public/interfaces/shelf.mojom

Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings. (Closed)
Patch Set: Fix struct traits typo. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/public/cpp/window_properties.cc ('k') | ash/shelf/app_list_shelf_item_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 module ash.mojom; 5 module ash.mojom;
6 6
7 import "mojo/common/string16.mojom"; 7 import "mojo/common/string16.mojom";
8 import "skia/public/interfaces/bitmap.mojom"; 8 import "skia/public/interfaces/bitmap.mojom";
9 import "ui/events/mojo/event.mojom"; 9 import "ui/events/mojo/event.mojom";
10 10
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 Type type; // The type of the menu item. 108 Type type; // The type of the menu item.
109 uint32 command_id; // The client's arbitrary item command id. 109 uint32 command_id; // The client's arbitrary item command id.
110 mojo.common.mojom.String16 label; // The string label, may be empty. 110 mojo.common.mojom.String16 label; // The string label, may be empty.
111 skia.mojom.Bitmap image; // The image icon, may be null. 111 skia.mojom.Bitmap image; // The image icon, may be null.
112 array<MenuItem>? submenu; // The optional nested submenu item list. 112 array<MenuItem>? submenu; // The optional nested submenu item list.
113 bool enabled; // The enabled state. 113 bool enabled; // The enabled state.
114 bool checked; // The checked state. 114 bool checked; // The checked state.
115 uint32 radio_group_id; // The radio group id. 115 uint32 radio_group_id; // The radio group id.
116 }; 116 };
117 117
118 // Identifier for shelf items and their windows.
119 // This structure matches ash::ShelfID.
120 struct ShelfID {
121 string app_id; // An app id string, used to match app windows.
122 // (eg. extension ids, arc ids, "AppList", etc.)
123 string launch_id; // A string used to support multiple items per app.
124 // (eg. Citrix may use 'Word' or 'Excel' launch ids)
125 };
126
118 // ShelfItems are used to populate the shelf. 127 // ShelfItems are used to populate the shelf.
119 // This structure matches ash::ShelfItem. 128 // This structure matches ash::ShelfItem.
120 struct ShelfItem { 129 struct ShelfItem {
121 ShelfItemType type; // The type of the shelf item. 130 ShelfItemType type; // The type of the shelf item.
122 skia.mojom.Bitmap image; // An icon image Bitmap, shown on the shelf. 131 skia.mojom.Bitmap image; // An icon image Bitmap, shown on the shelf.
123 int64 shelf_id; // A shelf model ID used by the shelf and clients.
124 ShelfItemStatus status; // The running/closed/etc. status of the item. 132 ShelfItemStatus status; // The running/closed/etc. status of the item.
125 string app_id; // An app id string, used to match app windows. 133 ShelfID shelf_id; // The id for the shelf item and its windows.
126 string launch_id; // A string used to support multiple items per app.
127 // (eg. Citrix may use 'Word' or 'Excel' launch ids)
128 mojo.common.mojom.String16 title; // The title to display for tooltips, etc. 134 mojo.common.mojom.String16 title; // The title to display for tooltips, etc.
129 bool shows_tooltip; // Whether the tooltip should be shown on hover. 135 bool shows_tooltip; // Whether the tooltip should be shown on hover.
130 bool pinned_by_policy; // Whether the item is pinned by policy preferences, 136 bool pinned_by_policy; // Whether the item is pinned by policy preferences,
131 // the user cannot un-pin these items. 137 // the user cannot un-pin these items.
132 }; 138 };
OLDNEW
« no previous file with comments | « ash/public/cpp/window_properties.cc ('k') | ash/shelf/app_list_shelf_item_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698