Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: ash/public/cpp/app_launch_id.h

Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings. (Closed)
Patch Set: Fix struct traits typo. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/mus_property_mirror_ash_unittest.cc ('k') | ash/public/cpp/app_launch_id.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/public/cpp/app_launch_id.h
diff --git a/ash/public/cpp/app_launch_id.h b/ash/public/cpp/app_launch_id.h
index 1b080ec5534db6ea075463734286eea6eaca061c..b725840c59d5a8a68487858de203d15d7619c92c 100644
--- a/ash/public/cpp/app_launch_id.h
+++ b/ash/public/cpp/app_launch_id.h
@@ -25,18 +25,21 @@ class ASH_PUBLIC_EXPORT AppLaunchId {
AppLaunchId();
~AppLaunchId();
- AppLaunchId(const AppLaunchId& app_launch_id) = default;
- AppLaunchId(AppLaunchId&& app_launch_id) = default;
- AppLaunchId& operator=(const AppLaunchId& other) = default;
+ AppLaunchId(const AppLaunchId& other);
+ AppLaunchId(AppLaunchId&& other);
+ AppLaunchId& operator=(const AppLaunchId& other);
+ bool operator==(const AppLaunchId& other) const;
+ bool operator!=(const AppLaunchId& other) const;
+ bool operator<(const AppLaunchId& other) const;
- const std::string& app_id() const { return app_id_; }
- const std::string& launch_id() const { return launch_id_; }
+ // Returns true if both the application id and launch id are empty.
+ // This is often used to determine if the id is invalid.
+ bool IsNull() const;
- private:
// The application id associated with a set of windows.
- std::string app_id_;
+ std::string app_id;
// An id passed on app launch, to support multiple shelf items per app.
- std::string launch_id_;
+ std::string launch_id;
};
} // namespace ash
« no previous file with comments | « ash/mus_property_mirror_ash_unittest.cc ('k') | ash/public/cpp/app_launch_id.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698