Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Side by Side Diff: ash/public/cpp/app_launch_id.h

Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings. (Closed)
Patch Set: Fix struct traits typo. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/mus_property_mirror_ash_unittest.cc ('k') | ash/public/cpp/app_launch_id.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_PUBLIC_CPP_APP_LAUNCH_ID_H_ 5 #ifndef ASH_PUBLIC_CPP_APP_LAUNCH_ID_H_
6 #define ASH_PUBLIC_CPP_APP_LAUNCH_ID_H_ 6 #define ASH_PUBLIC_CPP_APP_LAUNCH_ID_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "ash/public/cpp/ash_public_export.h" 10 #include "ash/public/cpp/ash_public_export.h"
11 11
12 namespace ash { 12 namespace ash {
13 13
14 // A unique shelf item id composed of an |app_id| and a |launch_id|. 14 // A unique shelf item id composed of an |app_id| and a |launch_id|.
15 // |app_id| is the non-empty application id associated with a set of windows. 15 // |app_id| is the non-empty application id associated with a set of windows.
16 // |launch_id| is passed on app launch, to support multiple shelf items per app. 16 // |launch_id| is passed on app launch, to support multiple shelf items per app.
17 // As an example, a remote desktop client may want each remote application to 17 // As an example, a remote desktop client may want each remote application to
18 // have its own icon. 18 // have its own icon.
19 class ASH_PUBLIC_EXPORT AppLaunchId { 19 class ASH_PUBLIC_EXPORT AppLaunchId {
20 public: 20 public:
21 AppLaunchId(const std::string& app_id, const std::string& launch_id); 21 AppLaunchId(const std::string& app_id, const std::string& launch_id);
22 // Creates an AppLaunchId with an empty |launch_id|. 22 // Creates an AppLaunchId with an empty |launch_id|.
23 explicit AppLaunchId(const std::string& app_id); 23 explicit AppLaunchId(const std::string& app_id);
24 // Empty constructor for pre-allocating. 24 // Empty constructor for pre-allocating.
25 AppLaunchId(); 25 AppLaunchId();
26 ~AppLaunchId(); 26 ~AppLaunchId();
27 27
28 AppLaunchId(const AppLaunchId& app_launch_id) = default; 28 AppLaunchId(const AppLaunchId& other);
29 AppLaunchId(AppLaunchId&& app_launch_id) = default; 29 AppLaunchId(AppLaunchId&& other);
30 AppLaunchId& operator=(const AppLaunchId& other) = default; 30 AppLaunchId& operator=(const AppLaunchId& other);
31 bool operator==(const AppLaunchId& other) const;
32 bool operator!=(const AppLaunchId& other) const;
33 bool operator<(const AppLaunchId& other) const;
31 34
32 const std::string& app_id() const { return app_id_; } 35 // Returns true if both the application id and launch id are empty.
33 const std::string& launch_id() const { return launch_id_; } 36 // This is often used to determine if the id is invalid.
37 bool IsNull() const;
34 38
35 private:
36 // The application id associated with a set of windows. 39 // The application id associated with a set of windows.
37 std::string app_id_; 40 std::string app_id;
38 // An id passed on app launch, to support multiple shelf items per app. 41 // An id passed on app launch, to support multiple shelf items per app.
39 std::string launch_id_; 42 std::string launch_id;
40 }; 43 };
41 44
42 } // namespace ash 45 } // namespace ash
43 46
44 #endif // ASH_PUBLIC_CPP_APP_LAUNCH_ID_H_ 47 #endif // ASH_PUBLIC_CPP_APP_LAUNCH_ID_H_
OLDNEW
« no previous file with comments | « ash/mus_property_mirror_ash_unittest.cc ('k') | ash/public/cpp/app_launch_id.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698