ash/shelf/shelf_tooltip_manager_unittest.cc - Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/shelf_tooltip_manager_unittest.cc

Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings. (Closed)

Patch Set: Restore AppLaunchId class via using ShelfID = AppLaunchId; cleanup. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/shelf/shelf_tooltip_manager_unittest.cc

diff --git a/ash/shelf/shelf_tooltip_manager_unittest.cc b/ash/shelf/shelf_tooltip_manager_unittest.cc

index 089e998b37c6b9fca180b4d8984002fdd66434d4..4512bdb611e5c0c09893d0405f8ff8345c9c39fe 100644

--- a/ash/shelf/shelf_tooltip_manager_unittest.cc

+++ b/ash/shelf/shelf_tooltip_manager_unittest.cc

@@ -85,6 +85,7 @@ TEST_F(ShelfTooltipManagerTest, DoNotShowForInvalidView) {

// The manager should start the timer for a view on the shelf.

ShelfModel* model = shelf_view_->model();

ShelfItem item;

+ item.id = ShelfID("foo");

item.type = TYPE_PINNED_APP;

const int index = model->Add(item);

// Note: There's no easy way to correlate shelf a model index/id to its view.