ash/public/cpp/shelf_types.cc - Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/public/cpp/shelf_types.cc

Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings. (Closed)

Patch Set: Restore AppLaunchId class via using ShelfID = AppLaunchId; cleanup. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/public/cpp/shelf_types.cc

diff --git a/ash/public/cpp/shelf_types.cc b/ash/public/cpp/shelf_types.cc

index a4cb0fd44fd23a19918f47c12e9868625cd41a02..7e670a7739545946ce52084d46a2748febd7114d 100644

--- a/ash/public/cpp/shelf_types.cc

+++ b/ash/public/cpp/shelf_types.cc

@@ -4,6 +4,8 @@

#include "ash/public/cpp/shelf_types.h"

+#include "base/logging.h"

msw 2017/05/04 14:17:30 self nit: removed

James Cook 2017/05/04 16:38:48 Huh?

msw 2017/05/04 19:05:57 ditto; maybe I should have written "nit: remove" o

namespace ash {

bool IsValidShelfItemType(int64_t type) {