ash/public/cpp/shelf_types.cc - Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/public/cpp/shelf_types.cc

Issue 2860503002: mash: Replace int ShelfIDs with AppLaunchID strings. (Closed)

Patch Set: Restore AppLaunchId class via using ShelfID = AppLaunchId; cleanup. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ash/public/cpp/shelf_types.h"	5 #include "ash/public/cpp/shelf_types.h"

6	6

	7 #include "base/logging.h"
	msw 2017/05/04 14:17:30 self nit: removed self nit: removed James Cook 2017/05/04 16:38:48 Huh? Show quoted text On 2017/05/04 14:17:30, msw wrote: > self nit: removed Huh? msw 2017/05/04 19:05:57 ditto; maybe I should have written "nit: remove" o Show quoted text On 2017/05/04 16:38:48, James Cook wrote: > On 2017/05/04 14:17:30, msw wrote: > > self nit: removed > > Huh? ditto; maybe I should have written "nit: remove" or "note to self: remove this"?
	8

7 namespace ash {	9 namespace ash {

8	10

9 bool IsValidShelfItemType(int64_t type) {	11 bool IsValidShelfItemType(int64_t type) {

10 return type == TYPE_APP_PANEL \|\| type == TYPE_PINNED_APP \|\|	12 return type == TYPE_APP_PANEL \|\| type == TYPE_PINNED_APP \|\|

11 type == TYPE_APP_LIST \|\| type == TYPE_BROWSER_SHORTCUT \|\|	13 type == TYPE_APP_LIST \|\| type == TYPE_BROWSER_SHORTCUT \|\|

12 type == TYPE_APP \|\| type == TYPE_DIALOG \|\| type == TYPE_UNDEFINED;	14 type == TYPE_APP \|\| type == TYPE_DIALOG \|\| type == TYPE_UNDEFINED;

13 }	15 }

14	16

15 } // namespace ash	17 } // namespace ash

OLD	NEW