Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2860483002: Add messageerror event handler (Closed)

Created:
3 years, 7 months ago by binji
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, falken+watch_chromium.org, haraken, horo+watch_chromium.org, kinuko+worker_chromium.org, rwlbuis, shimazu+worker_chromium.org, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add messageerror event handler This event is not currently wired up anywhere, but will be used in a subsequent CL. The idea is that when posting a message that cannot be decoded by the receiver, the receiver will dispatch a messageerror event instead of a message event. Spec changes: https://github.com/whatwg/html/pull/2530 web platform tests: https://github.com/w3c/web-platform-tests/pull/5567 Intent-to-implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Z_XzejHJTrs BUG=chromium:714842 Review-Url: https://codereview.chromium.org/2860483002 Cr-Commit-Position: refs/heads/master@{#471491} Committed: https://chromium.googlesource.com/chromium/src/+/2a863aff5dd967ab60b1ea2d17ac72c7cf2d6517

Patch Set 1 #

Patch Set 2 : fix webexposed tests #

Patch Set 3 : more test expectations #

Patch Set 4 : more test expectations #

Patch Set 5 : onmessageerror isn't on the global object in a service worker #

Patch Set 6 : merge HEAD #

Patch Set 7 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -6 lines) Patch
D third_party/WebKit/LayoutTests/external/wpt/webmessaging/messageerror-expected.txt View 1 2 3 4 5 6 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 8 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 8 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 5 4 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 8 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 4 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 5 4 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 8 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.h View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTypeNames.json5 View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindowEventHandlers.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/WindowEventHandlers.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAttributeNames.json5 View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLBodyElement.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 33 (25 generated)
binji
Still waiting on auto WPT import to pull the webmessaging/messageerror test.
3 years, 7 months ago (2017-05-02 22:55:12 UTC) #10
jochen (gone - plz use gerrit)
This requires an intent to ship (as it adds web exposed API). Can you send ...
3 years, 7 months ago (2017-05-03 10:40:40 UTC) #15
binji
On 2017/05/03 at 10:40:40, jochen wrote: > This requires an intent to ship (as it ...
3 years, 7 months ago (2017-05-03 18:03:18 UTC) #17
jochen (gone - plz use gerrit)
(waiting for the intent thread to move forward)
3 years, 7 months ago (2017-05-05 14:24:37 UTC) #18
binji
On 2017/05/05 at 14:24:37, jochen wrote: > (waiting for the intent thread to move forward) ...
3 years, 7 months ago (2017-05-11 22:21:01 UTC) #20
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-12 17:42:06 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860483002/120001
3 years, 7 months ago (2017-05-12 23:33:33 UTC) #30
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 23:42:02 UTC) #33
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/2a863aff5dd967ab60b1ea2d17ac...

Powered by Google App Engine
This is Rietveld 408576698