Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 2860473002: [Merge to M58] CrOS: Do not allow notifications to be added during shutdown. (Closed)

Created:
3 years, 7 months ago by sammiequon
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge to M58] CrOS: Do not allow notifications to be added during shutdown. Attempt to fix crash in the bug. I think the cause of this is a notification being added after the shutdown process has started. Somewhat confirmed this by sending a notification after shutdown. BUG=660962 TEST=unit_tests --gtest_filter="MessageCenterNotificationManagerTest.AddNotificationOnShutdown" Review-Url: https://codereview.chromium.org/2776933006 Cr-Commit-Position: refs/heads/master@{#460789} (cherry picked from commit ee04538066ee663d06c4d502435cbad08106a816) Review-Url: https://codereview.chromium.org/2860473002 . Cr-Commit-Position: refs/branch-heads/3029@{#790} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/8b8080a8da42c9a530d4baddfad2ccb5127b52af

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
sammiequon
3 years, 7 months ago (2017-05-02 17:11:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8b8080a8da42c9a530d4baddfad2ccb5127b52af.

Powered by Google App Engine
This is Rietveld 408576698