Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2860463003: Disable HotwordInstallerBrowserTest.AbortInstallOnShutdown on Windows. (Closed)

Created:
3 years, 7 months ago by Matt Giuca
Modified:
3 years, 7 months ago
Reviewers:
johnme, adithyas
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, rlp+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable HotwordInstallerBrowserTest.AbortInstallOnShutdown on Windows. Flaky on Windows because file handles may be open during shutdown (which causes TestingProfile to crash on shutdown). BUG=717648 Review-Url: https://codereview.chromium.org/2860463003 Cr-Commit-Position: refs/heads/master@{#469322} Committed: https://chromium.googlesource.com/chromium/src/+/a8ace33174ea8cd5ee2cf41804e0e0733be52dd3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/search/hotword_installer_browsertest.cc View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Matt Giuca
Hi, since you've been looking at this bug, can I get your LG (I am ...
3 years, 7 months ago (2017-05-04 03:20:02 UTC) #4
Matt Giuca
Feel free to put it in the CQ as well.
3 years, 7 months ago (2017-05-04 03:20:16 UTC) #5
johnme
lgtm + cq since there seems to be agreement on crbug.com/717648, and this is still ...
3 years, 7 months ago (2017-05-04 13:42:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860463003/1
3 years, 7 months ago (2017-05-04 13:42:45 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 13:47:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a8ace33174ea8cd5ee2cf41804e0...

Powered by Google App Engine
This is Rietveld 408576698