Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3921)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java

Issue 2860463002: [Suggestions] Remove TreeNode.getSuggestionAt() in favor of a visitor. (Closed)
Patch Set: review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java
index f8e02ed00193395bf94beb83c33faf7c9473eaec..d8e13b4e942cbbb2e55fdfe0832c3dea5065c56c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java
@@ -5,7 +5,6 @@
package org.chromium.chrome.browser.ntp.cards;
import org.chromium.base.Callback;
-import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;
import java.util.Set;
@@ -52,13 +51,6 @@ public interface TreeNode {
void onBindViewHolder(NewTabPageViewHolder holder, int position);
/**
- * @param position The position to query.
- * @return The article at {@code position} under this subtree, or null if the item is not
- * an article.
- */
- SnippetArticle getSuggestionAt(int position);
-
- /**
* @param position the position of an item to be dismissed.
* @return the set of item positions that should be dismissed simultaneously when dismissing the
* item at the given {@code position} (including the position itself), or an empty set
@@ -74,5 +66,12 @@ public interface TreeNode {
* it for accessibility purposes.
* @see NewTabPageAdapter#dismissItem
*/
- public void dismissItem(int position, Callback<String> itemRemovedCallback);
+ void dismissItem(int position, Callback<String> itemRemovedCallback);
+
+ /**
+ * Iterates over all items under this subtree and visits them with the given
+ * {@link NodeVisitor}.
+ * @param visitor The {@link NodeVisitor} with which to visit all items under this subtree.
+ */
+ void visitItems(NodeVisitor visitor);
}

Powered by Google App Engine
This is Rietveld 408576698