Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2860463002: [Suggestions] Remove TreeNode.getSuggestionAt() in favor of a visitor. (Closed)
Patch Set: review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
index 85540c7dfd12a4cb3bf70173fee29b7ce0d345b6..f4502db3d3259e196f139615cca05c5934f239c8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
@@ -137,7 +137,6 @@ public class SuggestionsSection extends InnerNode {
((SnippetArticleViewHolder) holder).onBindViewHolder(suggestion, mCategoryInfo);
}
- @Override
public SnippetArticle getSuggestionAt(int position) {
return mSuggestions.get(position);
}
@@ -181,6 +180,13 @@ public class SuggestionsSection extends InnerNode {
}
@Override
+ public void visitItems(NodeVisitor visitor) {
+ for (SnippetArticle suggestion : mSuggestions) {
+ visitor.visitSuggestion(suggestion);
+ }
+ }
+
+ @Override
public Set<Integer> getItemDismissalGroup(int position) {
return Collections.singleton(position);
}
@@ -323,7 +329,7 @@ public class SuggestionsSection extends InnerNode {
}
}
- public boolean hasSuggestions() {
+ private boolean hasSuggestions() {
return mSuggestionsList.getItemCount() != 0;
}

Powered by Google App Engine
This is Rietveld 408576698