LogDog Viewer: Link back to source build.

LogDog Viewer: Link back to source build.

As of tools/build commit 9d20a223d82b56419650d8fccbc85e05d81ca140,
LogDog streams may export a "logdog.viewer_url" tag that associates a
URL with the log stream. Update the viewer to check for this tag and, if
present, convert the log stream title at the top of the viewer into a
link pointing to that URL.

BUG=chromium:713986
TEST=local
  - Tested with a local viewer, seems to be working.

R=hinoka@chromium.org, nodir@chromium.org

Review-Url: https://codereview.chromium.org/2860453003
Committed: https://github.com/luci/luci-go/commit/be3ef4c9a4c295df8a50f7719f3e990cc57f2140

[nodir, 2017-05-03 15:36:52]

lgtm

https://codereview.chromium.org/2860453003/diff/1/web/inc/logdog-stream-view/...
File web/inc/logdog-stream-view/view.ts (right):

https://codereview.chromium.org/2860453003/diff/1/web/inc/logdog-stream-view/...
web/inc/logdog-stream-view/view.ts:54: /** If not null, link to this URL for the
log stream. */
null is not the same as undefined though

https://codereview.chromium.org/2860453003/diff/1/web/inc/logdog-stream-view/...
File web/inc/logdog-stream-view/viewer.ts (right):

https://codereview.chromium.org/2860453003/diff/1/web/inc/logdog-stream-view/...
web/inc/logdog-stream-view/viewer.ts:1055: this.sharedPrefix =
this.streams.every((entry) => {
I don't think this is used outside of this function, so posdibly this field is
unnecessary?

[dnj, 2017-05-03 15:40:43]

https://codereview.chromium.org/2860453003/diff/1/web/inc/logdog-stream-view/...
File web/inc/logdog-stream-view/view.ts (right):

https://codereview.chromium.org/2860453003/diff/1/web/inc/logdog-stream-view/...
web/inc/logdog-stream-view/view.ts:54: /** If not null, link to this URL for the
log stream. */
On 2017/05/03 15:36:52, nodir wrote:
> null is not the same as undefined though

Ah crap, used to be null, then decided undefined was better.

https://codereview.chromium.org/2860453003/diff/1/web/inc/logdog-stream-view/...
File web/inc/logdog-stream-view/viewer.ts (right):

https://codereview.chromium.org/2860453003/diff/1/web/inc/logdog-stream-view/...
web/inc/logdog-stream-view/viewer.ts:1055: this.sharedPrefix =
this.streams.every((entry) => {
On 2017/05/03 15:36:52, nodir wrote:
> I don't think this is used outside of this function, so posdibly this field is
> unnecessary?

Correct, I originally wanted to only return links for aggregate streams with a
shared prefix but then I decided that any link is better than none, so just do
it everywhere. Removed.

[dnj, 2017-05-03 15:40:53]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-05-03 15:40:53]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2860453003/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-05-03 15:41:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 15:47:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493826053431420,
"parent_rev": "8c40d0cab56cae963832053f96ae347866f3b847", "commit_rev":
"be3ef4c9a4c295df8a50f7719f3e990cc57f2140"}

[commit-bot: I haz the power, 2017-05-03 15:47:18]

Description was changed from

==========
LogDog Viewer: Link back to source build.

As of tools/build commit 9d20a223d82b56419650d8fccbc85e05d81ca140,
LogDog streams may export a "logdog.viewer_url" tag that associates a
URL with the log stream. Update the viewer to check for this tag and, if
present, convert the log stream title at the top of the viewer into a
link pointing to that URL.

BUG=chromium:713986
TEST=local
  - Tested with a local viewer, seems to be working.

R=hinoka@chromium.org, nodir@chromium.org
==========

to

==========
LogDog Viewer: Link back to source build.

As of tools/build commit 9d20a223d82b56419650d8fccbc85e05d81ca140,
LogDog streams may export a "logdog.viewer_url" tag that associates a
URL with the log stream. Update the viewer to check for this tag and, if
present, convert the log stream title at the top of the viewer into a
link pointing to that URL.

BUG=chromium:713986
TEST=local
  - Tested with a local viewer, seems to be working.

R=hinoka@chromium.org, nodir@chromium.org

Review-Url: https://codereview.chromium.org/2860453003
Committed:
https://github.com/luci/luci-go/commit/be3ef4c9a4c295df8a50f7719f3e990cc57f2140
==========

[commit-bot: I haz the power, 2017-05-03 15:47:19]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/be3ef4c9a4c295df8a50f7719f3e990cc57f2140