Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2860403002: [js-perf-tests] Fix PropertyQueries test for fast-delete (Closed)

Created:
3 years, 7 months ago by Jakob Kummerow
Modified:
3 years, 7 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[js-perf-tests] Fix PropertyQueries test for fast-delete Forcing an object into dictionary mode now requires deleting a property that's not the last property. BUG=chromium:718816 NOTRY=true Review-Url: https://codereview.chromium.org/2860403002 Cr-Commit-Position: refs/heads/master@{#45140} Committed: https://chromium.googlesource.com/v8/v8/+/1cda1732a7d285683aa7e466fbf392744ca6bd99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/js-perf-test/PropertyQueries/property-queries.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Jakob Kummerow
PTAL.
3 years, 7 months ago (2017-05-05 15:46:26 UTC) #2
Camillo Bruni
LGTM, much smart ;)
3 years, 7 months ago (2017-05-05 15:55:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860403002/1
3 years, 7 months ago (2017-05-05 15:56:27 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 15:57:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1cda1732a7d285683aa7e466fbf392744ca...

Powered by Google App Engine
This is Rietveld 408576698