Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2860363002: Fix GN bootstrap (Closed)

Created:
3 years, 7 months ago by Paweł Hajdan Jr.
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org, phajdan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN bootstrap This fixes the following compile error: c++ -pthread -o gn -Wl,--start-group tools/gn/gn_main.o libevent.a base.a xdg_user_dirs.a gn_lib.a dynamic_annotations.a -Wl,--end-group -lrt -latomic base/trace_event/trace_event_memory_overhead.o: In function `base::trace_event::TraceEventMemoryOverhead::AddString(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)': trace_event_memory_overhead.cc:(.text+0x228): undefined reference to `unsigned long base::trace_event::EstimateMemoryUsage<char, std::char_traits<char>, std::allocator<char> >(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' base/trace_event/trace_event_memory_overhead.o: In function `base::trace_event::TraceEventMemoryOverhead::AddRefCountedString(base::RefCountedString const&)': trace_event_memory_overhead.cc:(.text+0x267): undefined reference to `unsigned long base::trace_event::EstimateMemoryUsage<char, std::char_traits<char>, std::allocator<char> >(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' base/trace_event/trace_event_memory_overhead.o: In function `base::trace_event::TraceEventMemoryOverhead::AddValue(base::Value const&)': trace_event_memory_overhead.cc:(.text+0x309): undefined reference to `unsigned long base::trace_event::EstimateMemoryUsage<char, std::char_traits<char>, std::allocator<char> >(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' trace_event_memory_overhead.cc:(.text+0x409): undefined reference to `unsigned long base::trace_event::EstimateMemoryUsage<char, std::char_traits<char>, std::allocator<char> >(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' collect2: error: ld returned 1 exit status TBR=brettw BUG=none Review-Url: https://codereview.chromium.org/2860363002 . Cr-Commit-Position: refs/heads/master@{#469622} Committed: https://chromium.googlesource.com/chromium/src/+/9b718c790912bf0389fcd44bacf393d013ee1574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Paweł Hajdan Jr.
Committed patchset #1 (id:1) manually as 9b718c790912bf0389fcd44bacf393d013ee1574 (presubmit successful).
3 years, 7 months ago (2017-05-05 10:24:00 UTC) #3
Paweł Hajdan Jr.
TBR https://chromium.googlesource.com/chromium/src/+/b17ee3d6890cf542ff39366a5f6579d540314829/tools/gn/bootstrap/OWNERS
3 years, 7 months ago (2017-05-05 10:27:40 UTC) #5
Dirk Pranke
3 years, 7 months ago (2017-05-05 15:33:40 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698