Chromium Code Reviews
DescriptionA part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitBorder[Start|End|Before|After]Width from the switch statement in
parseSingleValue, and calls the API instead.
This patch:
- Adds parseSingleValue to -webkit-border-[start|end|before|after]-width in CSSProperties.json5
so that it will be added to the generated files for the api.
- Moves the parsing logic for the above properties from CSSPropertyParser.cpp to CSSPropertyAPIWebkitBorderWidth.cpp, which implements CSSPropertyAPI.h.
- Moves shared function ConsumeBorderWidth from CSSPropertyParser.cpp to CSSPropertyWebkitBorderWidthUtils.h.
Diff: https://gist.github.com/jm318/d277f7f4568a69fb5c11c02a6ac47f09/revisions
BUG=668012
Review-Url: https://codereview.chromium.org/2860333002
Cr-Commit-Position: refs/heads/master@{#469600}
Committed: https://chromium.googlesource.com/chromium/src/+/a22d5fb78823f01b93f1d62465fa178bd5e2b143
Patch Set 1 #
Messages
Total messages: 16 (11 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||