Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2860333002: Implements CSSPropertyAPI for the -webkit-border-[start|end|before|after]-width properties. (Closed)

Created:
3 years, 7 months ago by Jia
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10, Bugs Nash
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyWebkitBorder[Start|End|Before|After]Width from the switch statement in parseSingleValue, and calls the API instead. This patch: - Adds parseSingleValue to -webkit-border-[start|end|before|after]-width in CSSProperties.json5 so that it will be added to the generated files for the api. - Moves the parsing logic for the above properties from CSSPropertyParser.cpp to CSSPropertyAPIWebkitBorderWidth.cpp, which implements CSSPropertyAPI.h. - Moves shared function ConsumeBorderWidth from CSSPropertyParser.cpp to CSSPropertyWebkitBorderWidthUtils.h. Diff: https://gist.github.com/jm318/d277f7f4568a69fb5c11c02a6ac47f09/revisions BUG=668012 Review-Url: https://codereview.chromium.org/2860333002 Cr-Commit-Position: refs/heads/master@{#469600} Committed: https://chromium.googlesource.com/chromium/src/+/a22d5fb78823f01b93f1d62465fa178bd5e2b143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -14 lines) Patch
M third_party/WebKit/Source/core/css/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 4 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 4 chunks +3 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderWidth.cpp View 1 chunk +15 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyWebkitBorderWidthUtils.h View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyWebkitBorderWidthUtils.cpp View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Jia
3 years, 7 months ago (2017-05-05 03:17:54 UTC) #7
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-05 03:28:28 UTC) #8
Bugs Nash
lgtm \o/
3 years, 7 months ago (2017-05-05 05:16:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860333002/1
3 years, 7 months ago (2017-05-05 05:24:26 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 05:28:23 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a22d5fb78823f01b93f1d62465fa...

Powered by Google App Engine
This is Rietveld 408576698