Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2860323002: net: add IsMethodSafe() method to HttpUtil (Closed)

Created:
3 years, 7 months ago by tfarina
Modified:
3 years, 7 months ago
Reviewers:
Sami, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, bengr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

net: add IsMethodSafe() method to HttpUtil This consolidates the three copies of it in a single and accessible place. BUG=675760 TEST=net_unittests R=mmenke@chromium.org Review-Url: https://codereview.chromium.org/2860323002 Cr-Commit-Position: refs/heads/master@{#470211} Committed: https://chromium.googlesource.com/chromium/src/+/dbf45973be46d9dd01f8d7d3dadddef0eeeaff06

Patch Set 1 #

Patch Set 2 : \n #

Patch Set 3 : net:: #

Patch Set 4 : REBASE #

Patch Set 5 : remove IsMethodSafe() from generic_url_request_job.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -24 lines) Patch
M headless/lib/headless_browser_browsertest.cc View 1 2 3 chunks +2 lines, -7 lines 0 comments Download
M headless/public/util/generic_url_request_job.cc View 1 2 3 4 2 chunks +2 lines, -10 lines 0 comments Download
M net/http/http_util.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_util.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 38 (24 generated)
tfarina
3 years, 7 months ago (2017-05-05 01:32:19 UTC) #5
mmenke
LGTM!
3 years, 7 months ago (2017-05-05 14:37:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860323002/40001
3 years, 7 months ago (2017-05-05 16:33:05 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/428498)
3 years, 7 months ago (2017-05-05 16:42:33 UTC) #16
tfarina
+skyostil for headless/ OWNERS.
3 years, 7 months ago (2017-05-05 17:09:49 UTC) #18
Sami
headless/ lgtm, thank you!
3 years, 7 months ago (2017-05-08 17:16:22 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860323002/40001
3 years, 7 months ago (2017-05-08 17:22:12 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/288318)
3 years, 7 months ago (2017-05-08 21:58:51 UTC) #23
mmenke
On 2017/05/08 21:58:51, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 7 months ago (2017-05-08 22:01:20 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860323002/40001
3 years, 7 months ago (2017-05-08 22:02:24 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860323002/80001
3 years, 7 months ago (2017-05-08 22:44:30 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/263355) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 7 months ago (2017-05-09 00:21:57 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860323002/80001
3 years, 7 months ago (2017-05-09 00:40:13 UTC) #35
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 04:36:21 UTC) #38
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/dbf45973be46d9dd01f8d7d3dadd...

Powered by Google App Engine
This is Rietveld 408576698