|
|
Chromium Code Reviews
Descriptionnet: add IsMethodSafe() method to HttpUtil
This consolidates the three copies of it in a single and accessible place.
BUG=675760
TEST=net_unittests
R=mmenke@chromium.org
Review-Url: https://codereview.chromium.org/2860323002
Cr-Commit-Position: refs/heads/master@{#470211}
Committed: https://chromium.googlesource.com/chromium/src/+/dbf45973be46d9dd01f8d7d3dadddef0eeeaff06
Patch Set 1 #Patch Set 2 : \n #Patch Set 3 : net:: #Patch Set 4 : REBASE #Patch Set 5 : remove IsMethodSafe() from generic_url_request_job.cc #
Messages
Total messages: 38 (24 generated)
The CQ bit was checked by tfarina@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by tfarina@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tfarina@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM!
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
tfarina@chromium.org changed reviewers: + skyostil@chromium.org
+skyostil for headless/ OWNERS.
headless/ lgtm, thank you!
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by mmenke@chromium.org
On 2017/05/08 21:58:51, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, > https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) Looks like flake.
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by tfarina@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org, mmenke@chromium.org Link to the patchset: https://codereview.chromium.org/2860323002/#ps60001 (title: "REBASE")
The CQ bit was checked by tfarina@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org, mmenke@chromium.org Link to the patchset: https://codereview.chromium.org/2860323002/#ps80001 (title: "remove IsMethodSafe() from generic_url_request_job.cc")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494290164132870,
"parent_rev": "06f4ba114078db197f8b4a641145d2554d118d06", "commit_rev":
"dbf45973be46d9dd01f8d7d3dadddef0eeeaff06"}
Message was sent while issue was closed.
Description was changed from ========== net: add IsMethodSafe() method to HttpUtil This consolidates the three copies of it in a single and accessible place. BUG=675760 TEST=net_unittests R=mmenke@chromium.org ========== to ========== net: add IsMethodSafe() method to HttpUtil This consolidates the three copies of it in a single and accessible place. BUG=675760 TEST=net_unittests R=mmenke@chromium.org Review-Url: https://codereview.chromium.org/2860323002 Cr-Commit-Position: refs/heads/master@{#470211} Committed: https://chromium.googlesource.com/chromium/src/+/dbf45973be46d9dd01f8d7d3dadd... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/dbf45973be46d9dd01f8d7d3dadd... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
