Run SharedArrayBuffer WPT tests in virtual/sharedarraybuffer testsuite

Run SharedArrayBuffer WPT tests in virtual/sharedarraybuffer testsuite

This also fixes an issue in postMessage when
CanTransferArrayBuffersAndImageBitmaps is false (e.g. MessagePorts).
Previously, we would remove all transferables from the transferables list,
serialize that, then transfer the transferables separately. This prevents an
exception from being thrown when a SharedArrayBuffer is in the transferables
list.

BUG=chromium:716320
Review-Url: https://codereview.chromium.org/2860303002
Cr-Commit-Position: refs/heads/master@{#470154}
Committed: https://chromium.googlesource.com/chromium/src/+/43a78b926f0d6bdbaadbd804351cac6021415c97

[binji, 2017-05-05 00:39:42]

binji@chromium.org changed reviewers:
+ haraken@chromium.org

[binji, 2017-05-05 00:40:24]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 00:40:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 00:45:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 00:45:29]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[binji, 2017-05-05 00:51:06]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 00:51:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-05-05 00:52:53]

https://codereview.chromium.org/2860303002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp
(right):

https://codereview.chromium.org/2860303002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp:458:
array_buffers.end() - non_shared_begin);

Do we have a test case where shared array buffers are not stored in a contiguous
range?

  [NonShrared, Shared, Shared, NonShared, NonShared, Shared, NonShared, ...]

[commit-bot: I haz the power, 2017-05-05 02:40:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 02:40:23]

Dry run: This issue passed the CQ dry run.

[binji, 2017-05-05 18:53:39]

https://codereview.chromium.org/2860303002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp
(right):

https://codereview.chromium.org/2860303002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp:458:
array_buffers.end() - non_shared_begin);
On 2017/05/05 at 00:52:52, haraken wrote:
> Do we have a test case where shared array buffers are not stored in a
contiguous range?
> 
>   [NonShrared, Shared, Shared, NonShared, NonShared, Shared, NonShared, ...]

Nope, but I just added one.

[binji, 2017-05-05 18:53:51]

The CQ bit was checked by binji@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 18:54:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 21:06:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 21:06:17]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[haraken, 2017-05-06 14:56:34]

LGTM with a question.

https://codereview.chromium.org/2860303002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValue.cpp
(right):

https://codereview.chromium.org/2860303002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValue.cpp:457:
array_buffers.erase(non_shared_begin - array_buffers.begin(),

Would you help me understand what this erase is doing?

What we want to do here is to erase array buffers that was added to |result| at
line 456, right?

[binji, 2017-05-08 17:55:33]

The CQ bit was checked by binji@chromium.org

[binji, 2017-05-08 17:55:33]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2860303002/#ps60001
(title: "add comment to ExtractNonSharedArrayBuffers and merge HEAD")

[commit-bot: I haz the power, 2017-05-08 17:56:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 22:51:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 22:52:00]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[binji, 2017-05-09 01:19:24]

The CQ bit was checked by binji@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:22:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 03:40:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494292764301120,
"parent_rev": "6db8732a503df0baaf5a991e245bf81534a25192", "commit_rev":
"53488a4f52be79849a4a84b8598c9084b6172705"}

[commit-bot: I haz the power, 2017-05-09 03:40:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494292764301120,
"parent_rev": "02d415ed18cfa0abf711e71d84011bbb5f7d05af", "commit_rev":
"43a78b926f0d6bdbaadbd804351cac6021415c97"}

[commit-bot: I haz the power, 2017-05-09 03:40:57]

Description was changed from

==========
Run SharedArrayBuffer WPT tests in virtual/sharedarraybuffer testsuite

This also fixes an issue in postMessage when
CanTransferArrayBuffersAndImageBitmaps is false (e.g. MessagePorts).
Previously, we would remove all transferables from the transferables list,
serialize that, then transfer the transferables separately. This prevents an
exception from being thrown when a SharedArrayBuffer is in the transferables
list.

BUG=chromium:716320
==========

to

==========
Run SharedArrayBuffer WPT tests in virtual/sharedarraybuffer testsuite

This also fixes an issue in postMessage when
CanTransferArrayBuffersAndImageBitmaps is false (e.g. MessagePorts).
Previously, we would remove all transferables from the transferables list,
serialize that, then transfer the transferables separately. This prevents an
exception from being thrown when a SharedArrayBuffer is in the transferables
list.

BUG=chromium:716320

Review-Url: https://codereview.chromium.org/2860303002
Cr-Commit-Position: refs/heads/master@{#470154}
Committed:
https://chromium.googlesource.com/chromium/src/+/43a78b926f0d6bdbaadbd804351c...
==========

[commit-bot: I haz the power, 2017-05-09 03:40:58]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/43a78b926f0d6bdbaadbd804351c...