Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2860283002:
Clean-up in BindingmanagerImpl. (Closed)
|
Created:
3 years, 7 months ago by Jay Civelli Modified:
3 years, 7 months ago Reviewers:
boliu CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionClean-up in BindingmanagerImpl.
Now that BindingManagerImpl is running on 1 thread, we can remove
ManagedConnection.cleanUp() and some null check over connections.
Also ensuring we don't hold on to connections (in the moderate pool
or other member variables) when removed, so that we don't modify their
bindings from that point.
Also some minor clean-ups and renaming of variables.
BUG=689758
Review-Url: https://codereview.chromium.org/2860283002
Cr-Commit-Position: refs/heads/master@{#469788}
Committed: https://chromium.googlesource.com/chromium/src/+/3caa6e14cb856d09bc62c2bbbcae32e2aeadf95b
Patch Set 1 : Clean-up in BindingmanagerImpl. #
Messages
Total messages: 25 (21 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Description was changed from ========== Clean-up in BindingmanagerImpl. BUG= ========== to ========== Clean-up in BindingmanagerImpl. BUG=689758 ==========
The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
Patchset #1 (id:100001) has been deleted
Description was changed from ========== Clean-up in BindingmanagerImpl. BUG=689758 ========== to ========== Clean-up in BindingmanagerImpl. Now that BindingManagerImpl is running on 1 thread, we can remove ManagedConnection.cleanUp() and some null check over connections. Also some clean-ups and renaming of variables. BUG=689758 ==========
jcivelli@chromium.org changed reviewers: + boliu@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Clean-up in BindingmanagerImpl. Now that BindingManagerImpl is running on 1 thread, we can remove ManagedConnection.cleanUp() and some null check over connections. Also some clean-ups and renaming of variables. BUG=689758 ========== to ========== Clean-up in BindingmanagerImpl. Now that BindingManagerImpl is running on 1 thread, we can remove ManagedConnection.cleanUp() and some null check over connections. Also ensuring we don't hold on to connections (in the moderate pool or other member variables) when removed, so that we don't modify their bindings from that point. Also some minor clean-ups and renaming of variables. BUG=689758 ==========
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jcivelli@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1494024329889710,
"parent_rev": "99c145d628465ca7c71f46ae39fe875466e3fb5e", "commit_rev":
"3caa6e14cb856d09bc62c2bbbcae32e2aeadf95b"}
Message was sent while issue was closed.
Description was changed from ========== Clean-up in BindingmanagerImpl. Now that BindingManagerImpl is running on 1 thread, we can remove ManagedConnection.cleanUp() and some null check over connections. Also ensuring we don't hold on to connections (in the moderate pool or other member variables) when removed, so that we don't modify their bindings from that point. Also some minor clean-ups and renaming of variables. BUG=689758 ========== to ========== Clean-up in BindingmanagerImpl. Now that BindingManagerImpl is running on 1 thread, we can remove ManagedConnection.cleanUp() and some null check over connections. Also ensuring we don't hold on to connections (in the moderate pool or other member variables) when removed, so that we don't modify their bindings from that point. Also some minor clean-ups and renaming of variables. BUG=689758 Review-Url: https://codereview.chromium.org/2860283002 Cr-Commit-Position: refs/heads/master@{#469788} Committed: https://chromium.googlesource.com/chromium/src/+/3caa6e14cb856d09bc62c2bbbcae... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:120001) as https://chromium.googlesource.com/chromium/src/+/3caa6e14cb856d09bc62c2bbbcae... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
